Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WindowSizeType to script_traits. #13891

Merged
merged 1 commit into from Oct 22, 2016
Merged

Move WindowSizeType to script_traits. #13891

merged 1 commit into from Oct 22, 2016
+20 −20

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 22, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Move WindowSizeType to script_traits.
Loading status checks…
1a96733
@highfive
Copy link

highfive commented Oct 22, 2016

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/constellation.rs
  • @fitzgen: components/script/dom/bindings/trace.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_traits/lib.rs, components/script_traits/lib.rs
  • @KiChjang: components/script/dom/bindings/trace.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_traits/lib.rs, components/script_traits/lib.rs
@highfive
Copy link

highfive commented Oct 22, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 22, 2016

@bors-servo r=nox

Reviewed in #13816.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

📌 Commit 1a96733 has been approved by nox
@highfive highfive assigned nox and unassigned glennw Oct 22, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

⌛ Testing commit 1a96733 with merge 6be969a...
bors-servo added a commit that referenced this pull request Oct 22, 2016
@bors-servo
Auto merge of #13891 - servo:msg-min, r=nox
Loading status checks…
6be969a 
Move WindowSizeType to script_traits.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13891)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 22, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 1a96733 into master Oct 22, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 22, 2016
Merged
@SimonSapin SimonSapin deleted the msg-min branch Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @bors-servo @nox @glennw
You can’t perform that action at this time.