Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate `etc/ci/check_dynamic_symbols.py` #13946
Merged
Conversation
highfive
commented
Oct 27, 2016
|
Heads up! This PR modifies the following files:
|
etc/ci/check_dynamic_symbols.py
Outdated
|
|
||
| symbol_regex = re.compile(b"D \*UND\*\t(.*) (.*)$") | ||
| allowed_symbols = frozenset([b'unshare', b'malloc_usable_size']) | ||
| actual_symbols = set() | ||
|
|
||
| objdump_output = subprocess.check_output([ | ||
| 'arm-linux-androideabi-objdump', | ||
| os.environ['ANDROID_NDK'] + '/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-objdump', |
This comment has been minimized.
This comment has been minimized.
…nges
|
Ok, updated. |
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 28, 2016
Update `etc/ci/check_dynamic_symbols.py` Update `etc/ci/check_dynamic_symbols.py` to work after [the latest changes](#13945) in the Android build system. Part of #13154. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13946) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 28, 2016
Update `etc/ci/check_dynamic_symbols.py` Update `etc/ci/check_dynamic_symbols.py` to work after [the latest changes](#13945) in the Android build system. Part of #13154. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13946) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmatyas commentedOct 27, 2016
•
edited by larsbergstrom
Update
etc/ci/check_dynamic_symbols.pyto work after the latest changes in the Android build system.Part of #13154.
This change is