Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to 1.14.0-nightly (c59cb71d9 2016-10-26) #13949

Merged
merged 1 commit into from Oct 27, 2016
Merged

Update Rust to 1.14.0-nightly (c59cb71d9 2016-10-26) #13949

merged 1 commit into from Oct 27, 2016

Conversation

@nox
Copy link
Member

nox commented Oct 27, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Oct 27, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/codegen/CodegenRust.py, components/script/lib.rs, components/script/Cargo.toml
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/lib.rs, components/script/Cargo.toml
@highfive
Copy link

highfive commented Oct 27, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Oct 27, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2016

📌 Commit ee351b3 has been approved by larsbergstrom
@highfive highfive assigned larsbergstrom and unassigned KiChjang Oct 27, 2016
@KiChjang
Copy link
Member

KiChjang commented Oct 27, 2016

@bors-servo r+
@highfive highfive assigned KiChjang and unassigned larsbergstrom Oct 27, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #13872
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2016

📌 Commit ee351b3 has been approved by KiChjang
@mbrubeck
mbrubeck reviewed Oct 27, 2016
View changes
ports/cef/Cargo.lock
"checksum phf_codegen 0.7.17 (registry+https://github.com/rust-lang/crates.io-index)" = "563b670811792d49bff142e7bb9787530d9b689fb4c55c6c309822d8d956a242"
"checksum phf_generator 0.7.17 (registry+https://github.com/rust-lang/crates.io-index)" = "21416830a6c83526443b960fd41b5e18f64c4e4f90970499aeed2be592029042"
"checksum phf_macros 0.7.17 (registry+https://github.com/rust-lang/crates.io-index)" = "1ce32ea1f8124c0a5a67611e47d9deb1874d213154213e6659e385d477e65933"
"checksum phf_shared 0.7.17 (registry+https://github.com/rust-lang/crates.io-index)" = "4a65f09191172833c798d31e5317ecd1e4be890a3d5acc6c2f85e1460c8828bd"

This comment has been minimized.

Sign in to view
Copy link
@mbrubeck

mbrubeck Oct 27, 2016

Contributor

Do you know why these checksums are no longer in the CEF Cargo.lock?

This comment has been minimized.

Sign in to view
Copy link
@nox

nox Oct 27, 2016

Author Member

@mbrubeck Because I fail at updating Cargo.lock files by hand because cargo update can't handle multiple bumps with =x.y.z bounds at once.
@nox
Update Rust to 1.14.0-nightly (c59cb71d9 2016-10-26)
Loading status checks…
d6479c6
@nox nox force-pushed the nox:rustup branch from ee351b3 to d6479c6 Oct 27, 2016
@nox
Copy link
Member Author

nox commented Oct 27, 2016

@bors-servo r=larsbergstrom

@mbrubeck Fixed, thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2016

📌 Commit d6479c6 has been approved by larsbergstrom
@highfive highfive assigned larsbergstrom and unassigned KiChjang Oct 27, 2016
@nox
Copy link
Member Author

nox commented Oct 27, 2016

@bors-servo p=57
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2016

⌛ Testing commit d6479c6 with merge 7205d5a...
bors-servo added a commit that referenced this pull request Oct 27, 2016
@bors-servo
Auto merge of #13949 - nox:rustup, r=larsbergstrom
Loading status checks…
7205d5a 
Update Rust to 1.14.0-nightly (c59cb71d9 2016-10-26)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13949)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 27, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit d6479c6 into servo:master Oct 27, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrubeck mbrubeck

Assignees

@larsbergstrom larsbergstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @larsbergstrom @bors-servo @KiChjang @mbrubeck
You can’t perform that action at this time.