Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upglutin: Close the window if the event stream is closed. #13983
Merged
Conversation
Otherwise we can end up infinitely spinning for no good reason.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2016
glutin: Close the window if the event stream is closed. Otherwise we can end up infinitely spinning for no good reason. This happened today to me. Obviously the underlying situation is also buggy, but this seemed like a more sane behavior compared to infinitely spin waiting for a never-arriving event. r? @glennw <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13983) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedOct 30, 2016
•
edited by larsbergstrom
Otherwise we can end up infinitely spinning for no good reason.
This happened today to me. Obviously the underlying situation is also buggy, but this seemed like a more sane behavior compared to infinitely spin waiting for a never-arriving event.
r? @glennw
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is