Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various gfx cleanup. #14004

Merged
merged 5 commits into from Oct 31, 2016
Merged

Various gfx cleanup. #14004

merged 5 commits into from Oct 31, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 31, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 5 commits Oct 31, 2016
@Ms2ger
Remove FontContext::paint_font_from_template.
4ace1c1
@Ms2ger
Remove always-empty FontContext::paint_font_cache.
91a41b7
@Ms2ger
Remove unused FontContext::font_cache_thread().
63752f3
@Ms2ger
Update Azure.
1f109dd
@Ms2ger
Remove gfx_traits::color.
Loading status checks…
a9e3fe7
@highfive
Copy link

highfive commented Oct 31, 2016

Heads up! This PR modifies the following files:

  • @emilio: components/layout/display_list_builder.rs
@highfive
Copy link

highfive commented Oct 31, 2016

warning Warning warning

  • These commits modify gfx and layout code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Oct 31, 2016

r? @glennw
@highfive highfive assigned glennw and unassigned jdm Oct 31, 2016
@glennw
Copy link
Member

glennw commented Oct 31, 2016

@Ms2ger Not sure if those CI failures are relevant, the code changes look good to me though.
@jdm
Copy link
Member

jdm commented Oct 31, 2016

@bors-servo: r=glennw
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2016

📌 Commit a9e3fe7 has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2016

⌛ Testing commit a9e3fe7 with merge 1a213bf...
bors-servo added a commit that referenced this pull request Oct 31, 2016
@bors-servo
Auto merge of #14004 - servo:gfx, r=glennw
Loading status checks…
1a213bf 
Various gfx cleanup.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14004)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit a9e3fe7 into master Oct 31, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
dependency-ci Failed dependency checks
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the gfx branch Nov 2, 2016
@UK992 UK992 mentioned this pull request Dec 7, 2016
Merged
bors-servo added a commit to servo/rust-azure that referenced this pull request Dec 13, 2016
@bors-servo
Auto merge of #249 - UK992:win32, r=larsbergstrom
Loading status checks…
e1d527d 
Don't use Freetype on Windows

This PR removes `scaled_font` module which last usage was removed in servo/servo#14004
and also removes Freetype dependency on Windows.

cc @metajack @vvuk @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/249)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @jdm @glennw @bors-servo
You can’t perform that action at this time.