Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to 1.14.0-nightly (7c69b0d5a 2016-11-01) #14028

Merged
merged 4 commits into from Nov 3, 2016
Merged

Update Rust to 1.14.0-nightly (7c69b0d5a 2016-11-01) #14028

merged 4 commits into from Nov 3, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 2, 2016 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Nov 2, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/lib.rs
  • @KiChjang: components/script_traits/lib.rs, components/script_traits/lib.rs, components/script/lib.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/Cargo.toml, components/script/dom/validitystate.rs, components/script_layout_interface/lib.rs, components/script/dom/bindings/js.rs, components/script/dom/bindings/num.rs, components/script_layout_interface/Cargo.toml, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
  • @fitzgen: components/devtools_traits/Cargo.toml, components/devtools_traits/Cargo.toml, components/script_traits/lib.rs, components/script_traits/lib.rs, components/script/lib.rs, components/script/Cargo.toml, components/script/dom/validitystate.rs, components/devtools_traits/lib.rs, components/devtools_traits/lib.rs, components/script_layout_interface/lib.rs, components/script/dom/bindings/js.rs, components/script/dom/bindings/num.rs, components/script_layout_interface/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml
  • @emilio: components/style/Cargo.toml, components/style/lib.rs, ports/geckolib/Cargo.lock, components/layout/Cargo.toml, components/layout/lib.rs
@highfive
Copy link

highfive commented Nov 2, 2016

warning Warning warning

  • These commits modify gfx, layout, style, and script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Nov 2, 2016

@bors-servo r=nox,SimonSapin
@highfive highfive assigned nox and unassigned asajeffrey Nov 2, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2016

📌 Commit 714ed16 has been approved by nox,SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2016

⌛ Testing commit 714ed16 with merge 8c942dd...
bors-servo added a commit that referenced this pull request Nov 2, 2016
@bors-servo
Auto merge of #14028 - servo:rustup, r=nox,SimonSapin
Loading status checks…
8c942dd 
Update Rust to 1.14.0-nightly (7c69b0d5a 2016-11-01)

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14028)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 2, 2016

@nox, r+ on your commits

Reviewed 5 of 5 files at r1, 4 of 8 files at r4.
Review status: 7 of 41 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 2, 2016

@bors-servo try, p=100

Things blocked on things blocked on…
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2016

💔 Test failed - windows-dev
@nox nox force-pushed the rustup branch from 714ed16 to d3f2eb7 Nov 2, 2016
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 2, 2016

@bors-servo r=nox,SimonSapin

Updated lockfile.

Previous failure was:

ImportError: No module named urllib3
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2016

📌 Commit d3f2eb7 has been approved by nox,SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2016

⌛ Testing commit d3f2eb7 with merge 5d7fbc1...
bors-servo added a commit that referenced this pull request Nov 2, 2016
@bors-servo
Auto merge of #14028 - servo:rustup, r=nox,SimonSapin
Loading status checks…
5d7fbc1 
Update Rust to 1.14.0-nightly (7c69b0d5a 2016-11-01)

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14028)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2016

💔 Test failed - windows-dev
nox and others added 4 commits Nov 2, 2016
@nox
Update Rust to 1.14.0-nightly (7c69b0d5a 2016-11-01)
b640a83
@SimonSapin @nox
Use heapsize_derive instead of heapsize_plugin
5bb4c6c
@SimonSapin @nox
Remove unused dependency
b0cac45
@nox
Make #[derive(JSTraceable)] a procedural macro
Loading status checks…
3912962
@nox nox force-pushed the rustup branch from d3f2eb7 to 3912962 Nov 3, 2016
@nox
Copy link
Member

nox commented Nov 3, 2016

@bors-servo r=nox,SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

📌 Commit 3912962 has been approved by nox,SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

⌛ Testing commit 3912962 with merge b197cb7...
bors-servo added a commit that referenced this pull request Nov 3, 2016
@bors-servo
Auto merge of #14028 - servo:rustup, r=nox,SimonSapin
Loading status checks…
b197cb7 
Update Rust to 1.14.0-nightly (7c69b0d5a 2016-11-01)

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14028)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

💔 Test failed - linux-rel-wpt
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 3, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

⌛ Testing commit 3912962 with merge c6e15f8...
bors-servo added a commit that referenced this pull request Nov 3, 2016
@bors-servo
Auto merge of #14028 - servo:rustup, r=nox,SimonSapin
Loading status checks…
c6e15f8 
Update Rust to 1.14.0-nightly (7c69b0d5a 2016-11-01)

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14028)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 3912962 into master Nov 3, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
dependency-ci Failed dependency checks
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Nov 3, 2016
Merged
Merged
@SimonSapin SimonSapin deleted the rustup branch Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @highfive @nox @bors-servo @asajeffrey
You can’t perform that action at this time.