Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple improvements to `EventTarget` event firing. #14036

Merged
merged 3 commits into from Nov 4, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Nov 3, 2016

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Nov 3, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/htmliframeelement.rs, components/script/dom/document.rs, components/script/dom/htmllinkelement.rs, components/script/dom/eventtarget.rs, components/script/dom/worker.rs, components/script/dom/serviceworker.rs, components/script/dom/event.rs, components/script/dom/htmldetailselement.rs, components/script/dom/htmlformelement.rs, components/script/dom/serviceworkerglobalscope.rs, components/script/dom/htmlimageelement.rs, components/script/dom/websocket.rs, components/script/dom/htmlinputelement.rs, components/script/dom/serviceworkercontainer.rs, components/script/dom/mediaquerylist.rs
  • @KiChjang: components/script/dom/htmliframeelement.rs, components/script/dom/document.rs, components/script/dom/htmllinkelement.rs, components/script/dom/eventtarget.rs, components/script/dom/worker.rs, components/script/dom/serviceworker.rs, components/script/dom/event.rs, components/script/dom/htmldetailselement.rs, components/script/dom/htmlformelement.rs, components/script/dom/serviceworkerglobalscope.rs, components/script/dom/htmlimageelement.rs, components/script/dom/websocket.rs, components/script/dom/htmlinputelement.rs, components/script/dom/serviceworkercontainer.rs, components/script/dom/mediaquerylist.rs
@highfive

This comment has been minimized.

Copy link

highfive commented Nov 3, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
frewsxcv added a commit to servo/html5ever that referenced this pull request Nov 3, 2016
@KiChjang

This comment has been minimized.

Copy link
Member

KiChjang commented Nov 3, 2016

Looks like this fixes #13884.

@KiChjang

This comment has been minimized.

Copy link
Member

KiChjang commented Nov 3, 2016

Oh wait, no, this doesn't look like it's following the language from the spec update. Do you mind editing this PR or making a new one to properly address #13884?

@frewsxcv

This comment has been minimized.

Copy link
Member Author

frewsxcv commented Nov 3, 2016

Not too interested in that issue, so I'd prefer not to change this PR :)

@frewsxcv

This comment has been minimized.

Copy link
Member Author

frewsxcv commented Nov 3, 2016

Blocked Going to wait on #14043.

@frewsxcv frewsxcv force-pushed the frewsxcv:event branch from f5f7835 to f447040 Nov 3, 2016
@frewsxcv

This comment has been minimized.

Copy link
Member Author

frewsxcv commented Nov 3, 2016

Just rebased this off @SimonSapin's changes in #14043. I actually didn't need to do servo/html5ever#230 since event names (from what I understand) will now go in the servo_atoms crate.

@nox

This comment has been minimized.

Copy link
Member

nox commented Nov 4, 2016

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Nov 4, 2016

📌 Commit f447040 has been approved by nox

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Nov 4, 2016

⌛️ Testing commit f447040 with merge 73c9847...

bors-servo added a commit that referenced this pull request Nov 4, 2016
A couple improvements to `EventTarget` event firing.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14036)
<!-- Reviewable:end -->
@@ -330,7 +330,9 @@ impl Runnable for EventRunnable {

fn handler(self: Box<EventRunnable>) {
let target = self.target.root();
target.fire_event_with_params(&*self.name, self.bubbles, self.cancelable);
let bubbles = self.bubbles.clone();
let cancelable = self.cancelable.clone();

This comment has been minimized.

Copy link
@Ms2ger

Ms2ger Nov 4, 2016

Contributor

What's this about?

This comment has been minimized.

Copy link
@nox

nox Nov 4, 2016

Member

Oops, filed #14062.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Nov 4, 2016

@bors-servo bors-servo merged commit f447040 into servo:master Nov 4, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 4, 2016
2 of 5 tasks complete
@frewsxcv frewsxcv deleted the frewsxcv:event branch Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.