Fix test-wpt and test-css for Windows.

[metajack]

In addition to minor changes for Windows, this forces Windows Python to
be used for all Windows builds (instead of using Windows Python only for
pc-windows-msvc builds).

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #__ (github issue number if applicable).

• There are tests for these changes OR
• These changes do not require tests because testing the tests is too meta for me

---

This change is

[highfive]

Heads up! This PR modifies the following files:

• @wafflespeanut: python/servo/command_base.py, python/mach_bootstrap.py
• @jgraham: tests/wpt/run.py

[metajack]

r? @larsbergstrom

Also, perhaps @jgraham should look at the openssl change.

[jgraham]

Remeber the wptrunner changes need to be upstreamed.

---

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

python/mach_bootstrap.py, line 79 at r1 (raw file):

# Possible names of executables
if sys.platform in ['msys', 'win32']:

This could use a comment about why.

---

tests/wpt/web-platform-tests/tools/sslutils/openssl.py, line 60 at r1 (raw file):

        self.cmd += list(args)

        env = {}

Why?

---

Comments from Reviewable

[metajack]

@jgraham Added comments as requested. I'll prepare an upstream PR with the same diff in a bit.

[metajack]

Upstream PR is w3c/wpt-tools#139

[metajack]

Upstream PR has landed.

[jgraham]

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[metajack]

Updated to add correct PATH for AppVeyor gnu builds.

[jdm]

That has successfully returned us to the status quo of #13939.

[jgraham]

@bors-servo r+

[bors-servo]

📌 Commit 77ccb15 has been approved by jgraham

[bors-servo]

⌛ Testing commit 77ccb15 with merge 92115c7...

[bors-servo]

💔 Test failed - windows-dev

[metajack]

@bors-servo retry

• had to update windows builder for the correct PATH

[bors-servo]

⌛ Testing commit 77ccb15 with merge 9c2bb06...

[metajack]

@bors-servo try

[bors-servo]

⌛ Trying commit 7f8412c with merge 87f0d2c...

[bors-servo]

💔 Test failed - windows-dev

[metajack]

@bors-servo retry

• another time into the breach

[metajack]

@bors-servo r=jgraham

[bors-servo]

📌 Commit 8e8519d has been approved by jgraham

[bors-servo]

⌛ Testing commit 8e8519d with merge 17bf6ae...

[bors-servo]

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

[nox]

This patch makes people with non-UTF-8 environment variables unable to run tests. Was that intended? Can that be reverted?

[Manishearth]

Can someone address @nox's question? This is affecting me too.

[larsbergstrom]

The problem according to the comment is that non-UTF-8 environment variables cannot be passed to create process. What should we be doing here - it sounds like a fail either way?

I assume the options are:

1. Only do the UTF-8 filtering on windows
2. Just drop non-UTF-8 environment variables
3. Revert the patch, rebreak windows
   ?

[Manishearth]

I looked into this more, test-wpt now actually handles the error. test-css however has an older copy of sslutils.py which doesn't deal with this.

#15452 (comment)

I'm not sure which of these files we can edit and what the canonical source is.

[jdm]

You can do anything you want to test-css, because it's going away in #19070. The canonical source for those files is upstream web-platform-tests.