Fix test-wpt and test-css for Windows. #14039

metajack · 2016-11-03T04:48:37Z

In addition to minor changes for Windows, this forces Windows Python to
be used for all Windows builds (instead of using Windows Python only for
pc-windows-msvc builds).

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #__ (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because testing the tests is too meta for me

This change is

highfive · 2016-11-03T04:48:40Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/command_base.py, python/mach_bootstrap.py
@jgraham: tests/wpt/run.py

metajack · 2016-11-03T04:55:00Z

r? @larsbergstrom

Also, perhaps @jgraham should look at the openssl change.

jgraham · 2016-11-03T15:56:40Z

Remeber the wptrunner changes need to be upstreamed.

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

python/mach_bootstrap.py, line 79 at r1 (raw file):

# Possible names of executables
if sys.platform in ['msys', 'win32']:

This could use a comment about why.

tests/wpt/web-platform-tests/tools/sslutils/openssl.py, line 60 at r1 (raw file):

        self.cmd += list(args)

        env = {}

Why?

Comments from Reviewable

metajack · 2016-11-03T17:14:43Z

@jgraham Added comments as requested. I'll prepare an upstream PR with the same diff in a bit.

metajack · 2016-11-03T17:23:35Z

Upstream PR is w3c/wpt-tools#139

metajack · 2016-11-03T17:58:54Z

Upstream PR has landed.

jgraham · 2016-11-03T18:14:01Z

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

metajack · 2016-11-03T20:29:57Z

Updated to add correct PATH for AppVeyor gnu builds.

jdm · 2016-11-03T20:42:33Z

That has successfully returned us to the status quo of #13939.

jgraham · 2016-11-03T22:59:51Z

@bors-servo r+

bors-servo · 2016-11-03T22:59:53Z

📌 Commit 77ccb15 has been approved by jgraham

bors-servo · 2016-11-04T00:09:54Z

⌛ Testing commit 77ccb15 with merge 92115c7...


        Auto merge of #14039 - metajack:windows-wpt, r=jgraham

Fix test-wpt and test-css for Windows.  In addition to minor changes for Windows, this forces Windows Python to be used for all Windows builds (instead of using Windows Python only for pc-windows-msvc builds). ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [x] These changes do not require tests because testing the tests is too meta for me   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14039)

bors-servo · 2016-11-04T00:10:22Z

💔 Test failed - windows-dev

metajack · 2016-11-04T01:28:43Z

@bors-servo retry

had to update windows builder for the correct PATH

bors-servo · 2016-11-04T02:36:49Z

⌛ Testing commit 77ccb15 with merge 9c2bb06...


        Auto merge of #14039 - metajack:windows-wpt, r=jgraham

Fix test-wpt and test-css for Windows.  In addition to minor changes for Windows, this forces Windows Python to be used for all Windows builds (instead of using Windows Python only for pc-windows-msvc builds). ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [x] These changes do not require tests because testing the tests is too meta for me   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14039)

metajack · 2016-11-16T17:33:04Z

@bors-servo try

bors-servo · 2016-11-16T17:33:07Z

⌛ Trying commit 7f8412c with merge 87f0d2c...


        Auto merge of #14039 - metajack:windows-wpt, r=<try>

Fix test-wpt and test-css for Windows.  In addition to minor changes for Windows, this forces Windows Python to be used for all Windows builds (instead of using Windows Python only for pc-windows-msvc builds). ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [x] These changes do not require tests because testing the tests is too meta for me   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14039)

bors-servo · 2016-11-16T17:33:19Z

💔 Test failed - windows-dev


        Fix test-wpt and test-css for Windows.

In addition to minor changes for Windows, this forces Windows Python to be used for all Windows builds (instead of using Windows Python only for pc-windows-msvc builds).

metajack · 2016-11-16T17:38:58Z

@bors-servo retry

another time into the breach

metajack · 2016-11-16T17:39:46Z

@bors-servo r=jgraham

bors-servo · 2016-11-16T17:39:49Z

📌 Commit 8e8519d has been approved by jgraham

bors-servo · 2016-11-16T19:41:28Z

⌛ Testing commit 8e8519d with merge 17bf6ae...


        Auto merge of #14039 - metajack:windows-wpt, r=jgraham

Fix test-wpt and test-css for Windows.  In addition to minor changes for Windows, this forces Windows Python to be used for all Windows builds (instead of using Windows Python only for pc-windows-msvc builds). ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [x] These changes do not require tests because testing the tests is too meta for me   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14039)

bors-servo · 2016-11-16T21:05:57Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

upsuper · 2016-11-21T03:17:20Z

This change breaks building geckolib inside MozillaBuild. MozillaBuild is basically just a MINGW32 environment with Windows Python, so it has MSYSTEM environment.

metajack · 2016-11-21T04:06:22Z

I suggest adding a --target flag to mach then. Building from MSYSTEM seems like it should build mingw by default, at least until we make msvc the only target.

upsuper · 2016-11-21T04:34:45Z

Sounds reasonable.

upsuper · 2016-11-21T04:54:55Z

Actually, can we just use native rustc rather than downloading rustc for building geckolib?

metajack · 2016-11-21T05:05:54Z

You can override how rustc is chosen by using .servobuild. There should be an example in the file.

nox · 2017-02-08T12:43:53Z

This patch makes people with non-UTF-8 environment variables unable to run tests. Was that intended? Can that be reverted?

Manishearth · 2017-11-02T02:20:38Z

Can someone address @nox's question? This is affecting me too.

larsbergstrom · 2017-11-02T03:12:20Z

The problem according to the comment is that non-UTF-8 environment variables cannot be passed to create process. What should we be doing here - it sounds like a fail either way?

I assume the options are:

Only do the UTF-8 filtering on windows
Just drop non-UTF-8 environment variables
Revert the patch, rebreak windows
?

Manishearth · 2017-11-02T03:36:19Z

I looked into this more, test-wpt now actually handles the error. test-css however has an older copy of sslutils.py which doesn't deal with this.

#15452 (comment)

I'm not sure which of these files we can edit and what the canonical source is.

jdm · 2017-11-02T12:14:59Z

You can do anything you want to test-css, because it's going away in #19070. The canonical source for those files is upstream web-platform-tests.

highfive assigned pcwalton Nov 3, 2016

highfive added the S-awaiting-review label Nov 3, 2016

highfive assigned larsbergstrom and unassigned pcwalton Nov 3, 2016

metajack force-pushed the metajack:windows-wpt branch from 72333c1 to bce8980 Nov 3, 2016

metajack force-pushed the metajack:windows-wpt branch from bce8980 to 77ccb15 Nov 3, 2016

highfive assigned jgraham and unassigned larsbergstrom Nov 3, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 3, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 4, 2016

highfive removed the S-tests-failed label Nov 4, 2016

highfive added the S-tests-failed label Nov 16, 2016

metajack force-pushed the metajack:windows-wpt branch from 7f8412c to 77ccb15 Nov 16, 2016

highfive removed the S-tests-failed label Nov 16, 2016

Fix test-wpt and test-css for Windows.

Loading status checks…

8e8519d

In addition to minor changes for Windows, this forces Windows Python to be used for all Windows builds (instead of using Windows Python only for pc-windows-msvc builds).

metajack force-pushed the metajack:windows-wpt branch from 77ccb15 to 8e8519d Nov 16, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 16, 2016

bors-servo mentioned this pull request Nov 16, 2016

Immutable CSSOM #14190

Merged

3 of 3 tasks complete

bors-servo merged commit 8e8519d into servo:master Nov 16, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Nov 16, 2016

metajack deleted the metajack:windows-wpt branch Nov 16, 2016

jdm mentioned this pull request Dec 19, 2016

Run WPT/CSS tests on windows builders servo/saltfs#556

Open

nox mentioned this pull request Feb 8, 2017

Cannot run tests in presence of non-UTF-8 env variables #15452

Closed

jdm mentioned this pull request Jun 19, 2017

Running tests doesn't work on Windows 10 64-bit #17392

Closed

servo / servo

Join GitHub today

Fix test-wpt and test-css for Windows. #14039

Fix test-wpt and test-css for Windows. #14039

Conversation

metajack commented Nov 3, 2016 • edited by larsbergstrom

highfive commented Nov 3, 2016

metajack commented Nov 3, 2016

jgraham commented Nov 3, 2016

metajack commented Nov 3, 2016

metajack commented Nov 3, 2016

metajack commented Nov 3, 2016

jgraham commented Nov 3, 2016

metajack commented Nov 3, 2016

jdm commented Nov 3, 2016

jgraham commented Nov 3, 2016

bors-servo commented Nov 3, 2016

bors-servo commented Nov 4, 2016

bors-servo commented Nov 4, 2016

metajack commented Nov 4, 2016

bors-servo commented Nov 4, 2016

metajack commented Nov 16, 2016

bors-servo commented Nov 16, 2016

bors-servo commented Nov 16, 2016

metajack commented Nov 16, 2016

metajack commented Nov 16, 2016

bors-servo commented Nov 16, 2016

bors-servo commented Nov 16, 2016

bors-servo commented Nov 16, 2016

This comment has been minimized.

upsuper commented on python/servo/command_base.py in 8e8519d Nov 21, 2016

This comment has been minimized.

metajack replied Nov 21, 2016

This comment has been minimized.

upsuper replied Nov 21, 2016

This comment has been minimized.

upsuper replied Nov 21, 2016

This comment has been minimized.

metajack replied Nov 21, 2016

nox commented Feb 8, 2017

Manishearth commented Nov 2, 2017

larsbergstrom commented Nov 2, 2017

Manishearth commented Nov 2, 2017

jdm commented Nov 2, 2017

metajack commented Nov 3, 2016 •

edited by larsbergstrom

upsuper commented on `python/servo/command_base.py` in `8e8519d` Nov 21, 2016