Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the data_loader test with fetch. #14042

Merged
merged 6 commits into from Nov 3, 2016
Merged

Rewrite the data_loader test with fetch. #14042

merged 6 commits into from Nov 3, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 3, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 6 commits Nov 3, 2016
@Ms2ger
Move some helper functions to the root of the net tests crate.
a8f655c
@Ms2ger
Remove unnecessary extern crates from networking unit tests.
7e1c707
@Ms2ger
Make the data_loader test more efficient and readable.
7a311ea
@Ms2ger
Rewrite the data_loader test with fetch.
f304151
@Ms2ger
Move the test_fetch_data test.
bb9b0b3 
There is no longer any point in keeping it apart from the other data URL tests.
@Ms2ger
Make the data_loader module private.
Loading status checks…
6fcbc5b
@highfive
Copy link

highfive commented Nov 3, 2016

Heads up! This PR modifies the following files:
@nox
Copy link
Member

nox commented Nov 3, 2016

@bors-servo r+
@highfive highfive assigned nox and unassigned asajeffrey Nov 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

📌 Commit 6fcbc5b has been approved by nox
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 3, 2016

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

⌛ Testing commit 6fcbc5b with merge 05f4512...
bors-servo added a commit that referenced this pull request Nov 3, 2016
@bors-servo
Auto merge of #14042 - servo:fetch-unit-data, r=nox
Loading status checks…
05f4512 
Rewrite the data_loader test with fetch.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14042)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 6fcbc5b into master Nov 3, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
dependency-ci Failed dependency checks
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the fetch-unit-data branch Nov 4, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 7, 2016
Closed
31 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @nox @bors-servo @asajeffrey
You can’t perform that action at this time.