Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip dependencyci checks for known deprecated modules. #14045

Merged
merged 1 commit into from Nov 4, 2016
Merged

Skip dependencyci checks for known deprecated modules. #14045

merged 1 commit into from Nov 4, 2016

Conversation

@jdm
Copy link
Member

jdm commented Nov 3, 2016 •
edited by larsbergstrom

This change is Reviewable
@jdm jdm assigned jdm and unassigned glennw Nov 3, 2016
@jdm
Copy link
Member Author

jdm commented Nov 3, 2016

r? @larsbergstrom
This makes our DependencyCI build go green. I've also submitted librariesio/librarian-parsers#52 to avoid the confusion between our local crates and actual ones one crates.io.
@highfive highfive assigned larsbergstrom and unassigned jdm Nov 3, 2016
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 3, 2016

Does this need a squash? It looks like you've added and removed a bunch of interesting exclusions to the dependencyci.yml file in this commit sequence.
@jdm
Copy link
Member Author

jdm commented Nov 3, 2016

I did it all through the github UI, so couldn't amend. I can squash if you'd like.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Nov 3, 2016

r=me. A squash would be nice if you don't mind. Otherwise, the history will be a bit icky.
@jdm
Skip dependencyci checks for the charade module, which is out of our …
Loading status checks…
fe6d53e 
…control.
@jdm jdm force-pushed the jdm-patch-1 branch from 972df98 to fe6d53e Nov 3, 2016
@jdm
Copy link
Member Author

jdm commented Nov 3, 2016

@bors-servo: r=larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2016

📌 Commit fe6d53e has been approved by larsbergstrom
bors-servo added a commit that referenced this pull request Nov 4, 2016
@bors-servo
Auto merge of #14045 - servo:jdm-patch-1, r=larsbergstrom
Loading status checks…
4b383e1 
Skip dependencyci checks for known deprecated modules.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14045)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

⌛ Testing commit fe6d53e with merge 4b383e1...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Nov 4, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

⌛ Testing commit fe6d53e with merge 35b206a...
bors-servo added a commit that referenced this pull request Nov 4, 2016
@bors-servo
Auto merge of #14045 - servo:jdm-patch-1, r=larsbergstrom
Loading status checks…
35b206a 
Skip dependencyci checks for known deprecated modules.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14045)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit fe6d53e into master Nov 4, 2016
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the jdm-patch-1 branch Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @larsbergstrom @bors-servo @glennw @highfive
You can’t perform that action at this time.