Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix getElementsByTagName() #14047
Merged
fix getElementsByTagName() #14047
Conversation
highfive
commented
Nov 3, 2016
|
Heads up! This PR modifies the following files:
|
|
continuation of #12844 |
| } | ||
| } | ||
| return HTMLCollection::create(window, root, box AllFilter); | ||
| } |
This comment has been minimized.
This comment has been minimized.
frewsxcv
Nov 3, 2016
Member
Coincidentally, I opened #14033 yesterday. In my changes, I had another conditional branch here checking if qualified_name is lowercase, because if so, we wouldn't need to clone the Atom for a lowercase variant. It might have been overkill though.
This comment has been minimized.
This comment has been minimized.
|
|
mskrzypkows
force-pushed the
mskrzypkows:getElementsByTagName
branch
from
c69d2ac
to
73fc495
|
@nox r? |
|
@bors-servo r+ Thanks for keeping up with it! |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 4, 2016
fix getElementsByTagName() <!-- Please describe your changes on the following line: --> Improved implementation of getElementsByTagName() in Document, properly pass 3 cases of https://dom.spec.whatwg.org/#concept-getelementsbytagname --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11596 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14047) <!-- Reviewable:end -->
|
|
highfive
commented
Nov 4, 2016
|
|
@mskrzypkows Almost here, just need to remove that failure expectation. |
mskrzypkows
force-pushed the
mskrzypkows:getElementsByTagName
branch
from
73fc495
to
af5d109
|
@bors-servo: r=nox |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 4, 2016
fix getElementsByTagName() <!-- Please describe your changes on the following line: --> Improved implementation of getElementsByTagName() in Document, properly pass 3 cases of https://dom.spec.whatwg.org/#concept-getelementsbytagname --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11596 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14047) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mskrzypkows commentedNov 3, 2016
•
edited by larsbergstrom
Improved implementation of getElementsByTagName() in Document, properly pass 3 cases of https://dom.spec.whatwg.org/#concept-getelementsbytagname
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is