Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreachable_code warning. #14054

Merged
merged 1 commit into from Nov 4, 2016
Merged

Fix unreachable_code warning. #14054

merged 1 commit into from Nov 4, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 3, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 3, 2016

@bors-servo r+
@highfive highfive assigned SimonSapin and unassigned pcwalton Nov 3, 2016
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 4, 2016

@bors-servo r+

(After clicking "Synchronize" in the homu queue.)
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

📌 Commit 53a481c has been approved by SimonSapin
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 4, 2016

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

🔒 Merge conflict
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

☔ The latest upstream changes (presumably #14036) made this pull request unmergeable. Please resolve the merge conflicts.
@SimonSapin
Fix unreachable_code warning.
Loading status checks…
28b0269
@SimonSapin SimonSapin force-pushed the unreachable_code branch from 53a481c to 28b0269 Nov 4, 2016
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 4, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

📌 Commit 28b0269 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

⌛ Testing commit 28b0269 with merge 7c6793f...
bors-servo added a commit that referenced this pull request Nov 4, 2016
@bors-servo
Auto merge of #14054 - servo:unreachable_code, r=SimonSapin
Loading status checks…
7c6793f 
Fix unreachable_code warning.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14054)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

💔 Test failed - mac-rel-wpt2
@highfive
Copy link

highfive commented Nov 4, 2016 

  ▶ TIMEOUT [expected CRASH] /_mozilla/mozilla/sigsegv.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 4, 2016

@bors-servo retry

  • Filed #14067. I’m fairly confident it’s not caused by this PR, since this PR only updates one crate to a version that only adds #[allow(unreachable_code)].
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, windows-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 28b0269 into master Nov 4, 2016
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 4, 2016
Merged
0 of 3 tasks complete
@SimonSapin SimonSapin deleted the unreachable_code branch Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @bors-servo @Ms2ger @highfive @pcwalton
You can’t perform that action at this time.