Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privatize most of the net crate. #14063

Merged
merged 3 commits into from Nov 6, 2016
Merged

Privatize most of the net crate. #14063

merged 3 commits into from Nov 6, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 4, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Nov 4, 2016

Heads up! This PR modifies the following files:
@nox
Copy link
Member

nox commented Nov 4, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

📌 Commit d239980 has been approved by nox
@highfive highfive assigned nox and unassigned Manishearth Nov 4, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

⌛ Testing commit d239980 with merge c1ad922...
bors-servo added a commit that referenced this pull request Nov 4, 2016
@bors-servo
Auto merge of #14063 - servo:privatize-net, r=nox
Loading status checks…
c1ad922 
Privatize most of the net crate.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14063)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2016

💔 Test failed - linux-dev
@KiChjang
Copy link
Member

KiChjang commented Nov 4, 2016

Fails tidy:

./tests/unit/net/http_loader.rs:27: use statement is not in alphabetical order
    expected: net::test::{HttpResponse, LoadErrorType}
    found: net::resource_thread::{AuthCacheEntry, CancellationListener}
Ms2ger added 3 commits Nov 3, 2016
@Ms2ger
Privatize some net modules.
697275d
@Ms2ger
Privatize the http_loader module.
a888f07
@Ms2ger
Privatize the chrome_loader module.
Loading status checks…
88285b6
@Ms2ger Ms2ger force-pushed the privatize-net branch from d239980 to 88285b6 Nov 6, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 6, 2016

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

📌 Commit 88285b6 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

⌛ Testing commit 88285b6 with merge c62ce53...
bors-servo added a commit that referenced this pull request Nov 6, 2016
@bors-servo
Auto merge of #14063 - servo:privatize-net, r=nox
Loading status checks…
c62ce53 
Privatize most of the net crate.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14063)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 88285b6 into master Nov 6, 2016
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger mentioned this pull request Nov 7, 2016
Closed
31 of 31 tasks complete
@Ms2ger Ms2ger deleted the privatize-net branch Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-fails-tidy
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @nox @bors-servo @KiChjang @Manishearth
You can’t perform that action at this time.