Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement WebGLContext resize #14075
Merged
+34
−10
Conversation
highfive
commented
Nov 4, 2016
|
Heads up! This PR modifies the following files:
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 5, 2016
Implement WebGLContext resize <!-- Please describe your changes on the following line: --> Related PR: servo/webrender#519 Implement WebGLContext resize (canvas.width & canvas.height). I have tested: - Fixes WebGL apps that initialize canvas size after calling canvas.getContext("webgl") - Support WebGL apps that change the canvas size & viewport on window.onresize --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14075) <!-- Reviewable:end -->
|
|
|
@bors-servo retry Maybe intermittent? |
bors-servo
added a commit
that referenced
this pull request
Nov 9, 2016
Implement WebGLContext resize <!-- Please describe your changes on the following line: --> Related PR: servo/webrender#519 Implement WebGLContext resize (canvas.width & canvas.height). I have tested: - Fixes WebGL apps that initialize canvas size after calling canvas.getContext("webgl") - Support WebGL apps that change the canvas size & viewport on window.onresize --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14075) <!-- Reviewable:end -->
|
The test includes modifiying the canvas width and height, so this should probably be investigated! |
|
|
|
Yup, seems legit. Seems like we need to zero out the pixels that aren't in the current viewport set by |
|
@emilio After a resize we need to keep the default scissor that offscreen sets initially: https://github.com/emilio/rust-offscreen-rendering-context/blob/44e331217f958737349118969c4e73c96202440f/src/gl_context.rs#L187 I'll push a PR to conform the spec. |
|
@emilio We could do the change in Servo or offscreen-context, some pros an cons:
Let me know what do you think about this. |
|
I guess ideally we'll keep the WebGL-specific logic in Servo. I don't think an extra scissor call will be a perf issue here, but we can always re-consider if needed. |
bors-servo
added a commit
that referenced
this pull request
Nov 28, 2016
Implement WebGLContext resize <!-- Please describe your changes on the following line: --> Related PR: servo/webrender#519 Implement WebGLContext resize (canvas.width & canvas.height). I have tested: - Fixes WebGL apps that initialize canvas size after calling canvas.getContext("webgl") - Support WebGL apps that change the canvas size & viewport on window.onresize --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14075) <!-- Reviewable:end -->
|
|
The only other failure is #14380. |
MortimerGoro
force-pushed the
MortimerGoro:webgl-resize
branch
3 times, most recently
from
44a0dff
to
4761e51
|
It should be fixed now. Related PR: servo/surfman#75 Why does AppVeyor say that there is a conflict? I ran "./mach cargo-update -p offscreen_gl_context" after a clean rebase onto the latest master |
|
It seems you need to rebase according to github too... r=me when that's done. @bors-servo delegate+ |
|
|
|
It seems you need to rebase according to github too... r=me when that's done. @bors-servo delegate+ |
|
|
|
@emilio ouch, I did the merge upstream/master but forgot the rebase. Signals that it's time to go to bed ;) |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 1, 2016
Implement WebGLContext resize <!-- Please describe your changes on the following line: --> Related PR: servo/webrender#519 Implement WebGLContext resize (canvas.width & canvas.height). I have tested: - Fixes WebGL apps that initialize canvas size after calling canvas.getContext("webgl") - Support WebGL apps that change the canvas size & viewport on window.onresize --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14075) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MortimerGoro commentedNov 4, 2016
•
edited by larsbergstrom
Related PR: servo/webrender#519
Implement WebGLContext resize (canvas.width & canvas.height). I have tested:
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is