Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly expect a syntax error with :scope selectors in Element.closest #14080

Merged
merged 1 commit into from Nov 6, 2016

Conversation

@nox
Copy link
Member

nox commented Nov 5, 2016

This change is Reviewable

@SimonSapin
Copy link
Member

SimonSapin commented Nov 5, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2016

📌 Commit 1037fec has been approved by SimonSapin

@highfive highfive assigned SimonSapin and unassigned Ms2ger Nov 5, 2016
@SimonSapin
Copy link
Member

SimonSapin commented Nov 5, 2016

Spec change deferring this feature: w3c/csswg-drafts@9b7faa3

@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2016

Testing commit 1037fec with merge ca0bb0c...

bors-servo added a commit that referenced this pull request Nov 5, 2016
Properly expect a syntax error with :scope selectors in Element.closest

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14080)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

💔 Test failed - linux-rel-wpt

@nox
Copy link
Member Author

nox commented Nov 6, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

Testing commit 1037fec with merge dbf43c9...

bors-servo added a commit that referenced this pull request Nov 6, 2016
Properly expect a syntax error with :scope selectors in Element.closest

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14080)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

💔 Test failed - linux-rel-css

@nox
Copy link
Member Author

nox commented Nov 6, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

Previous build results for arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-css...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

@bors-servo bors-servo merged commit 1037fec into servo:master Nov 6, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:scope branch Aug 9, 2017
@upsuper
Copy link
Member

upsuper commented Oct 10, 2017

Note that :scope is not removed or deferred from Selectors Level 4, and both Gecko (pre-Stylo) and Blink support that pseudo-class, so it is incorrect to mark it not parsable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.