Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded #allow(unsafe_code) #14082

Merged
merged 1 commit into from Nov 6, 2016

Conversation

Projects
None yet
5 participants
@dns2utf8
Copy link
Contributor

commented Nov 5, 2016

I did #14065


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #14065
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Nov 5, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

commented Nov 5, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/mediaquerylist.rs
  • @KiChjang: components/script/dom/mediaquerylist.rs
@highfive

This comment has been minimized.

Copy link

commented Nov 5, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm

This comment has been minimized.

Copy link
Member

commented Nov 5, 2016

@bors-servo: r+
Thanks!

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2016

📌 Commit d2c2394 has been approved by jdm

@highfive highfive assigned jdm and unassigned pcwalton Nov 5, 2016

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2016

⌛️ Testing commit d2c2394 with merge 465619c...

bors-servo added a commit that referenced this pull request Nov 6, 2016

Auto merge of #14082 - dns2utf8:cleanup_14065, r=jdm
Remove unneeded #allow(unsafe_code)

I did #14065

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14065

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14082)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2016

@bors-servo bors-servo merged commit d2c2394 into servo:master Nov 6, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@dns2utf8 dns2utf8 deleted the dns2utf8:cleanup_14065 branch Nov 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.