Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect_mode to RequestInit #14083

Merged
merged 3 commits into from Nov 10, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -81,7 +81,7 @@ pub enum CacheMode {
}

/// [Redirect mode](https://fetch.spec.whatwg.org/#concept-request-redirect-mode)
#[derive(Copy, Clone, PartialEq, HeapSizeOf)]
#[derive(Copy, Clone, PartialEq, Serialize, Deserialize, HeapSizeOf)]
pub enum RedirectMode {
Follow,
Error,
@@ -137,6 +137,7 @@ pub struct RequestInit {
pub referrer_url: Option<Url>,
pub referrer_policy: Option<ReferrerPolicy>,
pub pipeline_id: Option<PipelineId>,
pub redirect_mode: RedirectMode,
}

impl Default for RequestInit {
@@ -158,6 +159,7 @@ impl Default for RequestInit {
referrer_url: None,
referrer_policy: None,
pipeline_id: None,
redirect_mode: RedirectMode::Follow,
}
}
}
@@ -266,6 +268,7 @@ impl Request {
};
req.referrer_policy.set(init.referrer_policy);
req.pipeline_id.set(init.pipeline_id);
req.redirect_mode.set(init.redirect_mode);
req
}

@@ -61,6 +61,7 @@ fn request_init_from_request(request: NetTraitsRequest) -> NetTraitsRequestInit
referrer_url: from_referrer_to_referrer_url(&request),
referrer_policy: request.referrer_policy.get(),
pipeline_id: request.pipeline_id.get(),
redirect_mode: request.redirect_mode.get(),
}
}

@@ -1,32 +1,17 @@
[redirect-mode-worker.html]
type: testharness
[Redirect 301 in "error" mode ]
expected: FAIL

[Redirect 301 in "manual" mode ]
expected: FAIL

[Redirect 302 in "error" mode ]
expected: FAIL

[Redirect 302 in "manual" mode ]
expected: FAIL

[Redirect 303 in "error" mode ]
expected: FAIL

[Redirect 303 in "manual" mode ]
expected: FAIL

[Redirect 307 in "error" mode ]
expected: FAIL

[Redirect 307 in "manual" mode ]
expected: FAIL

[Redirect 308 in "error" mode ]
expected: FAIL

[Redirect 308 in "manual" mode ]
expected: FAIL

@@ -1,32 +1,17 @@
[redirect-mode.html]
type: testharness
[Redirect 301 in "error" mode ]
expected: FAIL

[Redirect 301 in "manual" mode ]
expected: FAIL

[Redirect 302 in "error" mode ]
expected: FAIL

[Redirect 302 in "manual" mode ]
expected: FAIL

[Redirect 303 in "error" mode ]
expected: FAIL

[Redirect 303 in "manual" mode ]
expected: FAIL

[Redirect 307 in "error" mode ]
expected: FAIL

[Redirect 307 in "manual" mode ]
expected: FAIL

[Redirect 308 in "error" mode ]
expected: FAIL

[Redirect 308 in "manual" mode ]
expected: FAIL

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.