Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove CollectMemoryReports from compositor (fixes #13735) #14087
Conversation
highfive
commented
Nov 5, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
highfive
commented
Nov 5, 2016
|
Heads up! This PR modifies the following files:
|
| match reporter_request.to::<ReporterRequest>() { | ||
| Err(e) => error!("Cast to ReporterRequest failed ({}).", e), | ||
| Ok(reporter_request) => { | ||
| let msg = Msg::CollectMemoryReports(reporter_request.reports_channel); |
This comment has been minimized.
This comment has been minimized.
jdm
Nov 5, 2016
Member
I suspect the code that receives and processes this message can be removed as well. Probably the message variant from the enum, too.
|
@jdm thanks for the review, I've updated this PR |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 6, 2016
Remove CollectMemoryReports from compositor (fixes #13735) Remove all of the code in compositor.rs related to: * sending the RegisterReporter message * sending the UnregisterReporter message * the mem_profiler_chan member of IOCompositor * move the code that sends the ProfilerMsg::Exit message into Constellation::handle_exit instead --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13735 (github issue number if applicable). - [ ] There are tests for these changes OR - [x] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14087) <!-- Reviewable:end -->
|
|
highfive
commented
Nov 6, 2016
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Nov 6, 2016
Remove CollectMemoryReports from compositor (fixes #13735) Remove all of the code in compositor.rs related to: * sending the RegisterReporter message * sending the UnregisterReporter message * the mem_profiler_chan member of IOCompositor * move the code that sends the ProfilerMsg::Exit message into Constellation::handle_exit instead --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13735 (github issue number if applicable). - [ ] There are tests for these changes OR - [x] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14087) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Nov 6, 2016
Remove CollectMemoryReports from compositor (fixes #13735) Remove all of the code in compositor.rs related to: * sending the RegisterReporter message * sending the UnregisterReporter message * the mem_profiler_chan member of IOCompositor * move the code that sends the ProfilerMsg::Exit message into Constellation::handle_exit instead --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13735 (github issue number if applicable). - [ ] There are tests for these changes OR - [x] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14087) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MichaelKohler commentedNov 5, 2016
•
edited by larsbergstrom
Remove all of the code in compositor.rs related to:
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThese changes fix #13735 (github issue number if applicable).
There are tests for these changes OR
These changes do not require tests because _____
This change is