Make use of Servo-specific ToCss everywhere! #14089

wafflespeanut · 2016-11-06T11:13:47Z

This will allow types to be generic over our local ToCss

./mach build -d does not report any errors
./mach test-tidy does not report any errors

These changes do not require tests because it's a refactor

This change is

highfive · 2016-11-06T11:13:50Z

Heads up! This PR modifies the following files:

@bholley: components/style/values/computed/position.rs, components/style/values/specified/basic_shape.rs, components/style/properties/longhand/background.mako.rs, components/style/properties/longhand/text.mako.rs, components/style/properties/longhand/position.mako.rs, components/style/properties/longhand/outline.mako.rs, components/style/properties/longhand/list.mako.rs, components/style/properties/properties.mako.rs, components/style/viewport.rs, components/style/values/specified/image.rs, components/style/values/computed/basic_shape.rs, components/style/values/computed/image.rs, components/style/properties/longhand/font.mako.rs, components/style/properties/longhand/pointing.mako.rs, components/style/properties/longhand/inherited_box.mako.rs, components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/longhand/effects.mako.rs, components/style/properties/longhand/svg.mako.rs, components/style/values/specified/mod.rs, components/style/properties/longhand/counters.mako.rs, components/style/properties/declaration_block.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/border.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/custom_properties.rs, components/style/properties/shorthand/serialize.mako.rs, components/style/values/mod.rs, components/style/properties/helpers.mako.rs, components/style/properties/longhand/inherited_table.mako.rs, components/style/properties/helpers/animated_properties.mako.rs, components/style/properties/longhand/column.mako.rs, components/style/values/specified/position.rs
@emilio: components/style/values/computed/position.rs, components/style/values/specified/basic_shape.rs, components/style/properties/longhand/background.mako.rs, ports/geckolib/Cargo.lock, components/style/properties/longhand/text.mako.rs, components/style/properties/longhand/position.mako.rs, ports/geckolib/glue.rs, components/style/properties/longhand/outline.mako.rs, components/style/properties/longhand/list.mako.rs, components/style/properties/properties.mako.rs, components/style/viewport.rs, components/style/values/specified/image.rs, components/style/values/computed/basic_shape.rs, components/style/values/computed/image.rs, components/style/properties/longhand/font.mako.rs, components/style/properties/longhand/pointing.mako.rs, components/style/properties/longhand/inherited_box.mako.rs, components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/longhand/effects.mako.rs, components/style/properties/longhand/svg.mako.rs, components/style/values/specified/mod.rs, components/style/properties/longhand/counters.mako.rs, components/style/properties/declaration_block.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/border.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/custom_properties.rs, components/style/properties/shorthand/serialize.mako.rs, components/style/values/mod.rs, components/style/properties/helpers.mako.rs, components/style/properties/longhand/inherited_table.mako.rs, components/style/properties/helpers/animated_properties.mako.rs, components/style/properties/longhand/column.mako.rs, components/style/values/specified/position.rs

highfive · 2016-11-06T11:13:51Z

Warning

These commits modify style code, but no tests are modified. Please consider adding a test!

wafflespeanut · 2016-11-06T11:14:33Z

r? @SimonSapin

wafflespeanut · 2016-11-06T11:15:27Z

Okay, I just rebased. Both the builds succeed right now.

wafflespeanut · 2016-11-06T11:17:34Z

Also, currently, I've re-exported ToCss from values module, because when I began this, the idea was to make use of ToCss from values. Now, all the modules should make use of style_traits::ToCss.

wafflespeanut · 2016-11-06T12:24:41Z

This is ready for review! :)

SimonSapin · 2016-11-06T13:54:56Z

@bors-servo r+

Reviewed 5 of 6 files at r1, 43 of 43 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

bors-servo · 2016-11-06T13:54:57Z

📌 Commit 4df9824 has been approved by SimonSapin

wafflespeanut · 2016-11-06T13:56:07Z

@bors-servo r-

Oops. Just noticed the build failure in Travis. Gotta update the tests. Sorry 😞

wafflespeanut · 2016-11-06T15:57:44Z

@bors-servo r=SimonSapin

bors-servo · 2016-11-06T15:57:44Z

📌 Commit 173a866 has been approved by SimonSapin

bors-servo · 2016-11-06T16:10:06Z

⌛ Testing commit 173a866 with merge e2d3fcd...


        Auto merge of #14089 - Wafflespeanut:tocss, r=SimonSapin

Make use of Servo-specific ToCss everywhere!  This will allow types to be generic over our local `ToCss` ---  - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors  - [x] These changes do not require tests because it's a refactor   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14089)

bors-servo · 2016-11-06T16:30:19Z

💔 Test failed - linux-dev

wafflespeanut · 2016-11-06T16:31:24Z

Lockfile (sigh)

bors-servo · 2016-11-06T21:28:53Z

💔 Test failed - windows-dev


        Prefer Servo-specific ToCss for all types


        Fix the unit tests to make use of local ToCss

wafflespeanut · 2016-11-07T03:46:37Z

@bors-servo r=SimonSapin

bors-servo · 2016-11-07T03:46:39Z

📌 Commit 5ac1c11 has been approved by SimonSapin

bors-servo · 2016-11-07T03:46:41Z

⌛ Testing commit 5ac1c11 with merge 2f92fcb...


        Auto merge of #14089 - Wafflespeanut:tocss, r=SimonSapin

Make use of Servo-specific ToCss everywhere!  This will allow types to be generic over our local `ToCss` ---  - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors  - [x] These changes do not require tests because it's a refactor   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14089)

bors-servo · 2016-11-07T04:21:18Z

💔 Test failed - linux-rel-wpt

wafflespeanut · 2016-11-07T04:37:18Z

@bors-servo retry #14103

bors-servo · 2016-11-07T05:26:09Z

⌛ Testing commit 5ac1c11 with merge f48b3fe...


        Auto merge of #14089 - Wafflespeanut:tocss, r=SimonSapin

Make use of Servo-specific ToCss everywhere!  This will allow types to be generic over our local `ToCss` ---  - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors  - [x] These changes do not require tests because it's a refactor   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14089)

bors-servo · 2016-11-07T06:19:32Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

highfive assigned KiChjang Nov 6, 2016

highfive added the S-awaiting-review label Nov 6, 2016

highfive assigned SimonSapin and unassigned KiChjang Nov 6, 2016

wafflespeanut force-pushed the wafflespeanut:tocss branch 3 times, most recently from 4adc009 to 4df9824 Nov 6, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 6, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels Nov 6, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 6, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 6, 2016

wafflespeanut added 2 commits Nov 6, 2016

Prefer Servo-specific ToCss for all types

6061985

Fix the unit tests to make use of local ToCss

Loading status checks…

5ac1c11

wafflespeanut force-pushed the wafflespeanut:tocss branch from b734c6e to 5ac1c11 Nov 7, 2016

highfive added S-awaiting-review and removed S-tests-failed labels Nov 7, 2016

highfive removed the S-awaiting-review label Nov 7, 2016

highfive added the S-awaiting-merge label Nov 7, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 7, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Nov 7, 2016

bors-servo merged commit 5ac1c11 into servo:master Nov 7, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Nov 7, 2016

bors-servo mentioned this pull request Nov 7, 2016

Remove usage of 'keyword_list' #13917

Merged

3 of 3 tasks complete

wafflespeanut deleted the wafflespeanut:tocss branch Nov 7, 2016

wafflespeanut mentioned this pull request Nov 8, 2016

#13875 - Implement parsing/serialization for font-size-adjust. #14125

Merged

2 of 4 tasks complete

This was referenced Nov 8, 2016

Keep Property hacking guide wiki page up-to-date #14128

Closed

Implement parsing/serialization for font-size-adjust #13875

Closed

servo / servo

Make use of Servo-specific ToCss everywhere! #14089

Make use of Servo-specific ToCss everywhere! #14089

wafflespeanut commented Nov 6, 2016 •

edited

highfive commented Nov 6, 2016

highfive commented Nov 6, 2016

wafflespeanut commented Nov 6, 2016

wafflespeanut commented Nov 6, 2016 •

edited

wafflespeanut commented Nov 6, 2016 •

edited

wafflespeanut commented Nov 6, 2016

SimonSapin commented Nov 6, 2016

bors-servo commented Nov 6, 2016

wafflespeanut commented Nov 6, 2016

wafflespeanut commented Nov 6, 2016

bors-servo commented Nov 6, 2016

bors-servo commented Nov 6, 2016

bors-servo commented Nov 6, 2016

wafflespeanut commented Nov 6, 2016

bors-servo commented Nov 6, 2016

wafflespeanut commented Nov 7, 2016

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

wafflespeanut commented Nov 7, 2016

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

servo / servo

Join GitHub today

Make use of Servo-specific ToCss everywhere! #14089

Make use of Servo-specific ToCss everywhere! #14089

Conversation

wafflespeanut commented Nov 6, 2016 • edited

highfive commented Nov 6, 2016

highfive commented Nov 6, 2016

wafflespeanut commented Nov 6, 2016

wafflespeanut commented Nov 6, 2016 • edited

wafflespeanut commented Nov 6, 2016 • edited

wafflespeanut commented Nov 6, 2016

SimonSapin commented Nov 6, 2016

bors-servo commented Nov 6, 2016

wafflespeanut commented Nov 6, 2016

wafflespeanut commented Nov 6, 2016

bors-servo commented Nov 6, 2016

bors-servo commented Nov 6, 2016

bors-servo commented Nov 6, 2016

wafflespeanut commented Nov 6, 2016

bors-servo commented Nov 6, 2016

wafflespeanut commented Nov 7, 2016

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

wafflespeanut commented Nov 7, 2016

bors-servo commented Nov 7, 2016

bors-servo commented Nov 7, 2016

wafflespeanut commented Nov 6, 2016 •

edited

wafflespeanut commented Nov 6, 2016 •

edited

wafflespeanut commented Nov 6, 2016 •

edited