Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammatically correct the statement of bluetooth directory #14090

Merged
merged 1 commit into from Nov 6, 2016
Merged

Grammatically correct the statement of bluetooth directory #14090

merged 1 commit into from Nov 6, 2016

Conversation

@meetmangukiya
Copy link
Contributor

meetmangukiya commented Nov 6, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors -- Didn't check because it is doc update
  • ./mach test-tidy does not report any errors -- Didn't check because it is doc update
  • These changes fix #__ (github issue number if applicable). -- Didn't care to file a issue, but I can if it is needed
  • There are tests for these changes OR
  • These changes do not require tests because : It is a documentation update

This change is Reviewable
@meetmangukiya
Grammatically correct the statement of bluetooth directory
Loading status checks…
1781999
@highfive
Copy link

highfive commented Nov 6, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @KiChjang (or someone else) soon.
@meetmangukiya
Copy link
Contributor Author

meetmangukiya commented Nov 6, 2016

If not relevant, feel free to close it. In that case I'm sorry for the inconvenience 😟
@emilio
Copy link
Member

emilio commented Nov 6, 2016 •
edited

@bors-servo r+

It's fine, thanks for the fixup! :)
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

📌 Commit 1781999 has been approved by emilio
@highfive highfive assigned emilio and unassigned KiChjang Nov 6, 2016
bors-servo added a commit that referenced this pull request Nov 6, 2016
@bors-servo
Auto merge of #14090 - meetmangukiya:patch-1, r=emilio
Loading status checks…
c1926ed 
Grammatically correct the statement of bluetooth directory

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors -- *Didn't check because it is doc update*
- [ ] `./mach test-tidy` does not report any errors -- *Didn't check because it is doc update*
- [ ] These changes fix #__ (github issue number if applicable). -- *Didn't care to file a issue, but I can if it is needed*

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because : It is a documentation update

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14090)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

⌛ Testing commit 1781999 with merge c1926ed...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

📌 Commit 1781999 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

💔 Test failed - linux-rel-wpt
@emilio
Copy link
Member

emilio commented Nov 6, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

⌛ Testing commit 1781999 with merge 27592b5...
bors-servo added a commit that referenced this pull request Nov 6, 2016
@bors-servo
Auto merge of #14090 - meetmangukiya:patch-1, r=emilio
Loading status checks…
27592b5 
Grammatically correct the statement of bluetooth directory

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors -- *Didn't check because it is doc update*
- [ ] `./mach test-tidy` does not report any errors -- *Didn't check because it is doc update*
- [ ] These changes fix #__ (github issue number if applicable). -- *Didn't care to file a issue, but I can if it is needed*

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because : It is a documentation update

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14090)
<!-- Reviewable:end -->
@meetmangukiya
Copy link
Contributor Author

meetmangukiya commented Nov 6, 2016

Seems like failed again 😟
Wonder how could a doc file change makes tests to fail 🤔
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Nov 6, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

⌛ Testing commit 1781999 with merge fc9c1d2...
bors-servo added a commit that referenced this pull request Nov 6, 2016
@bors-servo
Auto merge of #14090 - meetmangukiya:patch-1, r=emilio
Loading status checks…
fc9c1d2 
Grammatically correct the statement of bluetooth directory

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors -- *Didn't check because it is doc update*
- [ ] `./mach test-tidy` does not report any errors -- *Didn't check because it is doc update*
- [ ] These changes fix #__ (github issue number if applicable). -- *Didn't care to file a issue, but I can if it is needed*

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because : It is a documentation update

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14090)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 1781999 into servo:master Nov 6, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@meetmangukiya
Copy link
Contributor Author

meetmangukiya commented Nov 7, 2016

This doesn't quite count as contribution, looking forward to contributing more. :)

A got a question, is servo for people into research? Is this a place for students like me (first year IT engineering)?
@jdm
Copy link
Member

jdm commented Nov 7, 2016

I'm not sure exactly what you're asking, but we are happy to collaborate with anybody interested in contributing code to an experimental web browser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@meetmangukiya @highfive @emilio @bors-servo @jdm @KiChjang
You can’t perform that action at this time.