Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canvas: Cleanup CanvasData and layout and script messages. #14099

Merged
merged 1 commit into from Nov 7, 2016
Merged

canvas: Cleanup CanvasData and layout and script messages. #14099

merged 1 commit into from Nov 7, 2016

Conversation

@emilio
Copy link
Member

emilio commented Nov 6, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because refactoring.

This change is Reviewable
@highfive
Copy link

highfive commented Nov 6, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/htmlcanvaselement.rs
  • @KiChjang: components/script/dom/htmlcanvaselement.rs
@highfive
Copy link

highfive commented Nov 6, 2016

warning Warning warning

  • These commits modify layout and script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Nov 6, 2016

r? @nox
@highfive highfive assigned nox and unassigned cbrewster Nov 6, 2016
@emilio
Copy link
Member Author

emilio commented Nov 6, 2016

This fixes #13734.
@emilio
Copy link
Member Author

emilio commented Nov 7, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

⌛ Trying commit ad0e944 with merge 09f1fb7...
bors-servo added a commit that referenced this pull request Nov 7, 2016
@bors-servo
Auto merge of #14099 - emilio:canvas-data, r=<try>
Loading status checks…
09f1fb7 
canvas: Cleanup CanvasData and layout and script messages.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because refactoring.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14099)
<!-- Reviewable:end -->
@nox
Copy link
Member

nox commented Nov 7, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

📌 Commit ad0e944 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward
@Ms2ger
Ms2ger reviewed Nov 7, 2016
View changes
components/script/dom/htmlcanvaselement.rs Outdated
=> return None,
Some(pixels) => pixels,
None => {
// TODO(emilio): Not sure if WebGL canvas is required for 2d

This comment has been minimized.

Sign in to view
Copy link
@Ms2ger

Ms2ger Nov 7, 2016

Contributor

I see no reason why it would not be required; please file an issue.

This comment has been minimized.

Sign in to view
Copy link
@emilio

emilio Nov 7, 2016

Author Member

Hmm, IIRC the last time I looked at this the canvas 2d spec only defined the behavior when another 2d canvas was provided, but yeah, worth investigating and fixing if required.
@nox
Copy link
Member

nox commented Nov 7, 2016

@bors-servo retry
@emilio
canvas: Cleanup CanvasData and layout and script messages.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
2e69143
@emilio emilio force-pushed the emilio:canvas-data branch from ad0e944 to 2e69143 Nov 7, 2016
@emilio
Copy link
Member Author

emilio commented Nov 7, 2016

@bors-servo r=nox

  • Updated the comment to point to #14109
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

📌 Commit 2e69143 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

⌛ Testing commit 2e69143 with merge 9588065...
bors-servo added a commit that referenced this pull request Nov 7, 2016
@bors-servo
Auto merge of #14099 - emilio:canvas-data, r=nox
Loading status checks…
9588065 
canvas: Cleanup CanvasData and layout and script messages.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because refactoring.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14099)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 2e69143 into servo:master Nov 7, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger

Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @bors-servo @nox @Ms2ger @cbrewster
You can’t perform that action at this time.