Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some misused promise_tests. #14113

Merged
merged 1 commit into from Nov 7, 2016
Merged

Fix some misused promise_tests. #14113

merged 1 commit into from Nov 7, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 7, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Fix some misused promise_tests.
Loading status checks…
a059b3e
@jdm
Copy link
Member

jdm commented Nov 7, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

📌 Commit a059b3e has been approved by jdm
@highfive highfive assigned jdm and unassigned cbrewster Nov 7, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 7, 2016
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

⌛ Testing commit a059b3e with merge f1c3e97...
bors-servo added a commit that referenced this pull request Nov 7, 2016
@bors-servo
Auto merge of #14113 - servo:promise_test, r=jdm
Loading status checks…
f1c3e97 
Fix some misused promise_tests.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14113)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit a059b3e into master Nov 7, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
dependency-ci Checking Dependencies
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the promise_test branch Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @jdm @bors-servo @highfive @cbrewster
You can’t perform that action at this time.