Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cors and redirect fetch tests. #14116

Merged
merged 1 commit into from Nov 8, 2016
Merged

Enable cors and redirect fetch tests. #14116

merged 1 commit into from Nov 8, 2016

Conversation

@jdm
Copy link
Member

jdm commented Nov 7, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Nov 7, 2016

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Nov 7, 2016

@bors-servo: r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2016

📌 Commit 3945de3 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned KiChjang Nov 7, 2016
@jdm jdm mentioned this pull request Nov 7, 2016
Closed
@Ms2ger Ms2ger mentioned this pull request Nov 7, 2016
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

⌛ Testing commit 3945de3 with merge d88a27a...
bors-servo added a commit that referenced this pull request Nov 8, 2016
@bors-servo
Auto merge of #14116 - jdm:fetch-reenable2, r=Manishearth
Loading status checks…
d88a27a 
Enable cors and redirect fetch tests.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14116)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

💔 Test failed - linux-rel-wpt
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 8, 2016 


Tests with unexpected results:
  ▶ Unexpected subtest result in /fetch/api/cors/cors-cookies-worker.html:
  └ PASS [expected FAIL] Include mode: 1 cookie

  ▶ Unexpected subtest result in /fetch/api/cors/cors-cookies-worker.html:
  │ FAIL [expected PASS] Include mode: local cookies are not sent with remote request
  │   → assert_false: Request should have no cookie expected false got true
  │ FAIL [expected PASS] Include mode: remote cookies are not sent with local request
  │   → assert_false: Request should have no cookie expected false got true
  │ FAIL [expected PASS] Same-origin mode: cookies are discarded in cors request
  │   → assert_false: Request should have no cookie expected false got true
  │ 
  └ corsCookies/</<@http://web-platform.test:8000/fetch/api/cors/cors-cookies.js:37:9

  ▶ Unexpected subtest result in /fetch/api/cors/cors-cookies.html:
  └ PASS [expected FAIL] Include mode: 1 cookie

  ▶ Unexpected subtest result in /fetch/api/cors/cors-cookies.html:
  │ FAIL [expected PASS] Include mode: local cookies are not sent with remote request
  │   → assert_false: Request should have no cookie expected false got true
  │ FAIL [expected PASS] Include mode: remote cookies are not sent with local request
  │   → assert_false: Request should have no cookie expected false got true
  │ FAIL [expected PASS] Same-origin mode: cookies are discarded in cors request
  │   → assert_false: Request should have no cookie expected false got true
  │ 
  └ corsCookies/</<@http://web-platform.test:8000/fetch/api/cors/cors-cookies.js:37:9

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/navigating-across-documents/002.html:
  │ FAIL [expected PASS] Multiple simultaneous navigations
  │   → assert_equals: expected "002-2" but got "002-1"
  │ 
  │ onmessage<@http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/002.html:13:3
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1401:20
  └ Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1425:20
@jdm
Enable cors and redirect fetch tests.
Loading status checks…
6589f61
@jdm jdm force-pushed the jdm:fetch-reenable2 branch from 3945de3 to 6589f61 Nov 8, 2016
@jdm
Copy link
Member Author

jdm commented Nov 8, 2016

@bors-servo: r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

📌 Commit 6589f61 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

⌛ Testing commit 6589f61 with merge e13bfeb...
bors-servo added a commit that referenced this pull request Nov 8, 2016
@bors-servo
Auto merge of #14116 - jdm:fetch-reenable2, r=Manishearth
Loading status checks…
e13bfeb 
Enable cors and redirect fetch tests.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14116)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 6589f61 into servo:master Nov 8, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 8, 2016
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @highfive @bors-servo @Ms2ger @Manishearth @KiChjang
You can’t perform that action at this time.