Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Response::url private. #14127

Merged
merged 2 commits into from Nov 10, 2016
Merged

Make Response::url private. #14127

merged 2 commits into from Nov 10, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 8, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Nov 8, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net_traits/response.rs, components/net_traits/response.rs, components/net/fetch/methods.rs
@highfive
Copy link

highfive commented Nov 8, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Nov 8, 2016

@bors-servo r+
@highfive highfive assigned nox and unassigned cbrewster Nov 8, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

📌 Commit 5b28a2d has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

⌛ Testing commit 5b28a2d with merge c7a3e59...
bors-servo added a commit that referenced this pull request Nov 8, 2016
@bors-servo
Auto merge of #14127 - servo:response-new-url, r=nox
Loading status checks…
c7a3e59 
Make Response::url private.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14127)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

💔 Test failed - linux-dev
@Ms2ger Ms2ger force-pushed the response-new-url branch from 5b28a2d to 9f40ae8 Nov 8, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 8, 2016

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

📌 Commit 9f40ae8 has been approved by nox
@Ms2ger Ms2ger mentioned this pull request Nov 8, 2016
Closed
31 of 31 tasks complete
@jdm
Copy link
Member

jdm commented Nov 8, 2016

@bors-servo: r-

error[E0382]: use of partially moved value: `fetch_response`

   --> /home/travis/build/servo/servo/tests/unit/net/fetch.rs:387:13

    |

386 |     assert!(fetch_response.url_list.into_inner().len() == 0);

    |             ----------------------- value moved here

387 |     assert!(fetch_response.url().is_none());

    |             ^^^^^^^^^^^^^^ value used here after move

    |

    = note: move occurs because `fetch_response.url_list` has type `std::cell::RefCell<std::vec::Vec<url::Url>>`, which does not implement the `Copy` trait

error: aborting due to previous error
Ms2ger added 2 commits Nov 7, 2016
@Ms2ger
Pass the URL to Response::new().
c1e1695
@Ms2ger
Make Response::url private.
Loading status checks…
15b55c3
@Ms2ger Ms2ger force-pushed the response-new-url branch from 9f40ae8 to 15b55c3 Nov 10, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 10, 2016

Let's try that again...

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2016

📌 Commit 15b55c3 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2016

⌛ Testing commit 15b55c3 with merge d8a0a00...
bors-servo added a commit that referenced this pull request Nov 10, 2016
@bors-servo
Auto merge of #14127 - servo:response-new-url, r=nox
Loading status checks…
d8a0a00 
Make Response::url private.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14127)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2016

💔 Test failed - linux-rel-css
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 10, 2016

@bors-servo retry #13775
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-css, mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 15b55c3 into master Nov 10, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the response-new-url branch Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @nox @bors-servo @jdm @cbrewster
You can’t perform that action at this time.