Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite some http unit tests with fetch. #14131

Merged
merged 4 commits into from Nov 8, 2016
Merged

Rewrite some http unit tests with fetch. #14131

merged 4 commits into from Nov 8, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 8, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 3 commits Nov 7, 2016
@Ms2ger
Rewrite test_load_when_request_is_not_get_or_head_and_there_is_no_bod…
Loading status checks…
06567e1 
…y_content_length_should_be_set_to_0.
@Ms2ger
Rewrite test_request_and_response_data_with_network_messages.
42f6e9a
@Ms2ger
Rewrite test_request_and_response_message_from_devtool_without_pipeli…
9b1e153 
…ne_id.
@jdm
Copy link
Member

jdm commented Nov 8, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

📌 Commit 52c25ca has been approved by jdm
@highfive highfive assigned jdm and unassigned KiChjang Nov 8, 2016
@Ms2ger
Rewrite test_redirected_request_to_devtools.
Loading status checks…
00e23a4
@Ms2ger Ms2ger force-pushed the fetch-unit-http branch from 52c25ca to 00e23a4 Nov 8, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 8, 2016

@bors-servo r=jdm

Removed a leftover logging line
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 8, 2016

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

📌 Commit 00e23a4 has been approved by jdm
@Ms2ger Ms2ger mentioned this pull request Nov 8, 2016
Closed
31 of 31 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

⌛ Testing commit 00e23a4 with merge 3ba56df...
bors-servo added a commit that referenced this pull request Nov 8, 2016
@bors-servo
Auto merge of #14131 - servo:fetch-unit-http, r=jdm
Loading status checks…
3ba56df 
Rewrite some http unit tests with fetch.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14131)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 00e23a4 into master Nov 8, 2016
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @jdm @bors-servo @KiChjang @highfive
You can’t perform that action at this time.