Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite some http unit tests with fetch. #14131

Merged
merged 4 commits into from Nov 8, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Rewrite test_request_and_response_data_with_network_messages.

  • Loading branch information
Ms2ger committed Nov 8, 2016
commit 42f6e9a8e661c579469b6a69fff0da0cf0239669
@@ -12,7 +12,7 @@ use flate2::Compression;
use flate2::write::{DeflateEncoder, GzEncoder};
use hyper::LanguageTag;
use hyper::header::{Accept, AcceptEncoding, ContentEncoding, ContentLength, Cookie as CookieHeader};
use hyper::header::{AcceptLanguage, Authorization, Basic};
use hyper::header::{AcceptLanguage, Authorization, Basic, Date};
use hyper::header::{Encoding, Headers, Host, Location, Quality, QualityItem, Referer, SetCookie, qitem};
use hyper::header::{StrictTransportSecurity, UserAgent};
use hyper::http::RawStatus;
@@ -458,31 +458,29 @@ fn test_load_when_request_is_not_get_or_head_and_there_is_no_body_content_length

#[test]
fn test_request_and_response_data_with_network_messages() {
struct Factory;

impl HttpRequestFactory for Factory {
type R = MockRequest;

fn create(&self, _: Url, _: Method, _: Headers) -> Result<MockRequest, LoadError> {
let mut headers = Headers::new();
headers.set(Host { hostname: "foo.bar".to_owned(), port: None });
Ok(MockRequest::new(
ResponseType::WithHeaders(<[_]>::to_vec("Yay!".as_bytes()), headers))
)
}
}

let http_state = HttpState::new();
let ui_provider = TestProvider::new();
let handler = move |_: HyperRequest, mut response: HyperResponse| {
response.headers_mut().set(Host { hostname: "foo.bar".to_owned(), port: None });
response.send(b"Yay!").unwrap();
};
let (mut server, url) = make_server(handler);

let url = Url::parse("https://mozilla.com").unwrap();
let (devtools_chan, devtools_port) = mpsc::channel::<DevtoolsControlMsg>();
let mut load_data = LoadData::new(LoadContext::Browsing, url.clone(), &HttpTest);
let mut request_headers = Headers::new();
request_headers.set(Host { hostname: "bar.foo".to_owned(), port: None });
load_data.headers = request_headers.clone();
let _ = load(&load_data, &ui_provider, &http_state, Some(devtools_chan), &Factory,
DEFAULT_USER_AGENT.into(), &CancellationListener::new(None), None);
let request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
headers: request_headers,
body: None,
destination: Destination::Document,
origin: url.clone(),
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let (devtools_chan, devtools_port) = mpsc::channel();
let response = fetch_sync(request, Some(devtools_chan));
assert!(response.status.unwrap().is_success());

let _ = server.close();

// notification received from devtools
let devhttprequest = expect_devtools_http_request(&devtools_port);
@@ -497,7 +495,7 @@ fn test_request_and_response_data_with_network_messages() {
qitem(Encoding::EncodingExt("br".to_owned()))
]));

headers.set(Host { hostname: "mozilla.com".to_owned() , port: None });
headers.set(Host { hostname: url.host_str().unwrap().to_owned() , port: url.port() });

let accept = Accept(vec![
qitem(Mime(TopLevel::Text, SubLevel::Html, vec![])),
@@ -517,7 +515,7 @@ fn test_request_and_response_data_with_network_messages() {
QualityItem::new(en, Quality(500)),
]));

headers.set(UserAgent(DEFAULT_USER_AGENT.to_owned()));
headers.set(UserAgent(::DEFAULT_USER_AGENT.to_owned()));

let httprequest = DevtoolsHttpRequest {
url: url,
@@ -536,6 +534,7 @@ fn test_request_and_response_data_with_network_messages() {
let mut response_headers = Headers::new();
response_headers.set(ContentLength(content.len() as u64));
response_headers.set(Host { hostname: "foo.bar".to_owned(), port: None });
response_headers.set(devhttpresponse.headers.as_ref().unwrap().get::<Date>().unwrap().clone());

let httpresponse = DevtoolsHttpResponse {
headers: Some(response_headers),
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.