Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log debug messages when devtools is not notified about a HTTP request. #14133

Merged
merged 1 commit into from Nov 9, 2016
Merged

Log debug messages when devtools is not notified about a HTTP request. #14133

merged 1 commit into from Nov 9, 2016

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 8, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

highfive commented Nov 8, 2016

Heads up! This PR modifies the following files:

@highfive
Copy link

highfive commented Nov 8, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 8, 2016
@nox
Copy link
Contributor

nox commented Nov 8, 2016

@bors-servo r+

@highfive highfive assigned nox and unassigned Manishearth Nov 8, 2016
@bors-servo
Copy link
Contributor

📌 Commit 783f754 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 8, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 8, 2016
Closed
31 tasks
@bors-servo
Copy link
Contributor

⌛ Testing commit 783f754 with merge 1dcacdd...

bors-servo pushed a commit that referenced this pull request Nov 9, 2016
Auto merge of #14133 - servo:debug-net-devtools, r=nox
1dcacdd 
Log debug messages when devtools is not notified about a HTTP request.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14133)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 9, 2016
@jdm
Copy link
Member

jdm commented Nov 9, 2016

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 783f754 with merge 3410242...

bors-servo pushed a commit that referenced this pull request Nov 9, 2016
Auto merge of #14133 - servo:debug-net-devtools, r=nox
3410242 
Log debug messages when devtools is not notified about a HTTP request.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14133)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 9, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

@bors-servo bors-servo merged commit 783f754 into master Nov 9, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 9, 2016
@Ms2ger Ms2ger deleted the debug-net-devtools branch November 9, 2016 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ms2ger @highfive @nox @bors-servo @jdm @Manishearth