Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass a borrowed fetch context to fetch(). #14138

Merged
merged 1 commit into from Nov 9, 2016
Merged

Pass a borrowed fetch context to fetch(). #14138

merged 1 commit into from Nov 9, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 8, 2016 •
edited by mbrubeck

This change is Reviewable
@Ms2ger
Pass a borrowed fetch context to fetch().
Loading status checks…
234b47e 
This will allow inspecting its state after fetching in unit tests.
@highfive
Copy link

highfive commented Nov 8, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/fetch/methods.rs, components/net/resource_thread.rs
@Ms2ger Ms2ger mentioned this pull request Nov 8, 2016
Closed
31 of 31 tasks complete
@KiChjang
Copy link
Member

KiChjang commented Nov 8, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2016

📌 Commit 234b47e has been approved by KiChjang
@highfive highfive assigned KiChjang and unassigned SimonSapin Nov 8, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2016

⌛ Testing commit 234b47e with merge 9d1c1f4...
bors-servo added a commit that referenced this pull request Nov 9, 2016
@bors-servo
Auto merge of #14138 - servo:fetch-context, r=KiChjang
Loading status checks…
9d1c1f4 
Pass a borrowed fetch context to fetch().

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14138)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 234b47e into master Nov 9, 2016
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the fetch-context branch Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @KiChjang @bors-servo @SimonSapin
You can’t perform that action at this time.