Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite some http unit tests with fetch. #14149

Merged
merged 5 commits into from Nov 9, 2016
Merged

Rewrite some http unit tests with fetch. #14149

merged 5 commits into from Nov 9, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 9, 2016 •
edited by larsbergstrom

This change is Reviewable
@jdm
jdm requested changes Nov 9, 2016
View changes
tests/unit/net/http_loader.rs
}
}
let post_handler = move |request: HyperRequest, response: HyperResponse| {
assert_eq!(request.method, Method::Get);

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Nov 9, 2016

Member

Let's verify that there's no body for consistency.
@Ms2ger Ms2ger force-pushed the fetch-unit-http branch from 28e6adb to 4bb289d Nov 9, 2016
Ms2ger added 5 commits Nov 8, 2016
@Ms2ger
Rewrite test_load_when_redirecting_from_a_post_should_rewrite_next_re…
90dd7c9 
…quest_as_get.
@Ms2ger
Rewrite test_load_should_decode_the_response_as_deflate_when_response…
4fe105b 
…_headers_have_content_encoding_deflate.
@Ms2ger
Rewrite test_load_should_decode_the_response_as_gzip_when_response_he…
ba86d85 
…aders_have_content_encoding_gzip.
@Ms2ger
Rewrite test_load_doesnt_send_request_body_on_any_redirect.
f03a600 
Note that it is necessary to use POST here; using GET will cause an error in
hyper, which enforces the rule that GET requests don't have a body.
@Ms2ger
Rewrite test_load_doesnt_add_host_to_sts_list_when_url_is_http_even_i…
Loading status checks…
2744227 
…f_sts_headers_are_present.
@Ms2ger Ms2ger force-pushed the fetch-unit-http branch from 4bb289d to 2744227 Nov 9, 2016
@jdm
Copy link
Member

jdm commented Nov 9, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2016

📌 Commit 2744227 has been approved by jdm
@highfive highfive assigned jdm and unassigned metajack Nov 9, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2016

⌛ Testing commit 2744227 with merge 289a289...
bors-servo added a commit that referenced this pull request Nov 9, 2016
@bors-servo
Auto merge of #14149 - servo:fetch-unit-http, r=jdm
Loading status checks…
289a289 
Rewrite some http unit tests with fetch.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 2744227 into master Nov 9, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the fetch-unit-http branch Nov 10, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 18, 2016
Closed
31 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @jdm @bors-servo @metajack @highfive
You can’t perform that action at this time.