Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify assert_cookie_for_domain. #14151

Merged
merged 1 commit into from Nov 10, 2016
Merged

Clarify assert_cookie_for_domain. #14151

merged 1 commit into from Nov 10, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 9, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Clarify assert_cookie_for_domain.
Loading status checks…
d31188f
@jdm
Copy link
Member

jdm commented Nov 9, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 9, 2016

📌 Commit d31188f has been approved by jdm
@highfive highfive assigned jdm and unassigned pcwalton Nov 9, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2016

⌛ Testing commit d31188f with merge a5fe3c6...
bors-servo added a commit that referenced this pull request Nov 10, 2016
@bors-servo
Auto merge of #14151 - servo:assert_cookie_for_domain, r=jdm
Loading status checks…
a5fe3c6 
Clarify assert_cookie_for_domain.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14151)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2016

💔 Test failed - mac-rel-wpt1
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 10, 2016

@bors-servo retry #13400
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2016

⌛ Testing commit d31188f with merge 89c4636...
bors-servo added a commit that referenced this pull request Nov 10, 2016
@bors-servo
Auto merge of #14151 - servo:assert_cookie_for_domain, r=jdm
Loading status checks…
89c4636 
Clarify assert_cookie_for_domain.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14151)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 10, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit d31188f into master Nov 10, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the assert_cookie_for_domain branch Nov 10, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 18, 2016
Closed
31 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @jdm @bors-servo @pcwalton @highfive
You can’t perform that action at this time.