Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite some http unit tests with fetch. #14163

Merged
merged 12 commits into from Nov 12, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Rewrite test_load_uses_explicit_accept_from_headers_in_load_data.

  • Loading branch information
Ms2ger committed Nov 10, 2016
commit 6319d7cb990bad9203aa9f14165379169ef244fa
@@ -1063,28 +1063,30 @@ fn test_load_sets_content_length_to_length_of_request_body() {

#[test]
fn test_load_uses_explicit_accept_from_headers_in_load_data() {
let text_html = qitem(Mime(TopLevel::Text, SubLevel::Html, vec![]));
let accept = Accept(vec![qitem(Mime(TopLevel::Text, SubLevel::Html, vec![]))]);
let expected_accept = accept.clone();
let handler = move |request: HyperRequest, response: HyperResponse| {
assert_eq!(request.headers.get::<Accept>(), Some(&expected_accept));
response.send(b"Yay!").unwrap();
};
let (mut server, url) = make_server(handler);

let mut accept_headers = Headers::new();
accept_headers.set(Accept(vec![text_html.clone()]));

let url = Url::parse("http://mozilla.com").unwrap();
let mut load_data = LoadData::new(LoadContext::Browsing, url.clone(), &HttpTest);

load_data.data = Some(<[_]>::to_vec("Yay!".as_bytes()));
load_data.headers.set(Accept(vec![text_html.clone()]));
accept_headers.set(accept);
let request = Request::from_init(RequestInit {
url: url.clone(),
method: Method::Get,
headers: accept_headers,
destination: Destination::Document,
origin: url.clone(),
pipeline_id: Some(TEST_PIPELINE_ID),
.. RequestInit::default()
});
let response = fetch_sync(request, None);

let http_state = HttpState::new();
let ui_provider = TestProvider::new();
let _ = server.close();

let _ = load(&load_data,
&ui_provider, &http_state,
None,
&AssertMustIncludeHeadersRequestFactory {
expected_headers: accept_headers,
body: <[_]>::to_vec("Yay!".as_bytes())
}, DEFAULT_USER_AGENT.into(),
&CancellationListener::new(None), None);
assert!(response.status.unwrap().is_success());
}

#[test]
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.