Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Don't assume siblings are alive in the rule tree when removing ourselves from the child list. #14167
Conversation
… ourselves from the child list. We can't assume all our siblings are alive because they may very well be in the free list too. This tempts to happen when the rule nodes are destroyed as part of the last GC, the one that runs in the root destructor. Also, properly put the next sibling back into the list when the rules are GCd.
highfive
commented
Nov 10, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Nov 10, 2016
|
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Nov 10, 2016
style: Don't assume siblings are alive in the rule tree when removing ourselves from the child list. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> We can't assume all our siblings are alive because they may very well be in the free list too. This tempts to happen when the rule nodes are destroyed as part of the last GC, the one that runs in the root destructor. Also, properly put the next sibling back into the list when the rules are GCd.
|
r? @SimonSapin |
|
|
|
The failure was #11100. |
|
Actually, simon is going to be away tomorrow. This can wait if needed, but blocks #8600 (or at least appears in the test failures), so... r? @Manishearth |
|
@bors-servo r+ |
|
|
|
@bors-servo retry
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 11, 2016
style: Don't assume siblings are alive in the rule tree when removing ourselves from the child list. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> We can't assume all our siblings are alive because they may very well be in the free list too. This tempts to happen when the rule nodes are destroyed as part of the last GC, the one that runs in the root destructor. Also, properly put the next sibling back into the list when the rules are GCd. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14167) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedNov 10, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsWe can't assume all our siblings are alive because they may very well be in the
free list too.
This tempts to happen when the rule nodes are destroyed as part of the last GC,
the one that runs in the root destructor.
Also, properly put the next sibling back into the list when the rules are GCd.
This change is