Return `KeyReaction::Nothing` for a Tab event

[jmcomets]

Do nothing instead of triggering the default action for a tab event.

Hitting the tab key in an html text input shouldn't submit the form, and for any text input, the tab key should have a particular action associated, not the default action.
This cleans up #12701.

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors

---

This change is 

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

[highfive]

Heads up! This PR modifies the following files:

• @fitzgen: components/script/dom/htmlinputelement.rs, components/script/textinput.rs
• @KiChjang: components/script/dom/htmlinputelement.rs, components/script/textinput.rs

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[metajack]

Looks good, but appears you accidentally deleted a TODO.

[metajack]

Was it intentional that you removed this TODO?

[jmcomets]

It was, but I hesitated. I commented on #3982, explaining that I believe
form keyboard navigation shouldn't be implemented on an HTMLInputElement,
but globally. This TODO implies that #3982 should be implemented there,
which is why I deleted it.

On Sat, Nov 12, 2016 at 4:33 PM Jack Moffitt notifications@github.com
wrote:

@metajack requested changes on this pull request.

Looks good, but appears you accidentally deleted a TODO.

In components/script/dom/htmlinputelement.rs
#14184 (review):

@@ -1097,18 +1096,10 @@ impl VirtualMethods for HTMLInputElement {
let action = self.textinput.borrow_mut().handle_keydown(keyevent);
match action {
TriggerDefaultAction => {

•                        if let Some(key) = keyevent.get_key() {
  

•                            match key {
  

•                                Key::Enter | Key::KpEnter =>
  

•                                    self.implicit_submission(keyevent.CtrlKey(),
  

•                                                             keyevent.ShiftKey(),
  

•                                                             keyevent.AltKey(),
  

•                                                             keyevent.MetaKey()),
  

•                                // Issue #12071: Tab should not submit forms
  

•                                // TODO(3982): Implement form keyboard navigation
  

Was it intentional that you removed this TODO?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#14184 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABzmgyy5p_QDE_7SyH27gbfFcoy25-Ciks5q9dxRgaJpZM4Kwb5Y
.

[metajack]

@bors-servo r+

That's fair.

[bors-servo]

📌 Commit 3191536 has been approved by metajack

[bors-servo]

⌛ Testing commit 3191536 with merge f04033a...

[bors-servo]

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev