Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few minimal debugging docs. #14187

Merged
merged 3 commits into from Nov 13, 2016
Merged

Add a few minimal debugging docs. #14187

merged 3 commits into from Nov 13, 2016

Conversation

@emilio
Copy link
Member

emilio commented Nov 12, 2016 •
edited by larsbergstrom

r? @jdm (or anyone else)

This change is Reviewable
@emilio
layout: Only specify parking_lot's `nightly` feature in `layout_thread`.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
5746a94 
This makes necessary only one line change to remove it if needed.
@highfive
Copy link

highfive commented Nov 12, 2016

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Nov 12, 2016

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@emilio
python: Make --debugger imply --debug
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
157c167
@emilio emilio force-pushed the emilio:rr-docs branch from 05cfc2b to 93d8225 Nov 12, 2016
@jdm
jdm requested changes Nov 13, 2016
View changes
Copy link
Member

jdm left a comment

This is a nice improvement over the status quo of no docs :)
docs/debugging.md Outdated
## Debugging SpiderMonkey.

You can build Servo with a debug version of SpiderMonkey passing the
`--debug-mozjs` flag to `mach`.

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Nov 13, 2016

Member

./mach build
docs/debugging.md Outdated
`--debug-mozjs` flag to `mach`.

Note that this sometimes can cause problems when an existing build exists, so
you might have to delete the `mozjs` build directory, or running `./mach clean`.

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Nov 13, 2016

Member 
or run `./mach clean` before performing the first `--debug-mozjs` build.
@emilio
docs: Add a minimal debugging guide.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
6c5cb9c
@emilio emilio force-pushed the emilio:rr-docs branch from 93d8225 to 6c5cb9c Nov 13, 2016
@emilio
Copy link
Member Author

emilio commented Nov 13, 2016

Amended, let me know if you think it's good to go :)
@jdm
Copy link
Member

jdm commented Nov 13, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2016

📌 Commit 6c5cb9c has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2016

⌛ Testing commit 6c5cb9c with merge bfd4a0e...
bors-servo added a commit that referenced this pull request Nov 13, 2016
@bors-servo
Auto merge of #14187 - emilio:rr-docs, r=jdm
Loading status checks…
bfd4a0e 
Add a few minimal debugging docs.

r? @jdm (or anyone else)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14187)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 6c5cb9c into servo:master Nov 13, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 13, 2016
Merged
0 of 5 tasks complete
@emilio emilio deleted the emilio:rr-docs branch Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@emilio @highfive @jdm @bors-servo
You can’t perform that action at this time.