Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVarious cleanup #14193
Merged
Various cleanup #14193
Conversation
highfive
commented
Nov 13, 2016
|
|
|
Great work! r? @larsbergstrom or @vvuk |
|
r=me Great! I notice that we still install freetype.. we should be able to remove that, as long as we've killed all downstream uses. (Now that I think of it, it may still be hanging on via skia maybe..) |
leeoniya
commented
Nov 14, 2016
|
related quasi-meta for this: #14176 |
|
@bors-servo: r=vvuk |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 14, 2016
Various cleanup <!-- Please describe your changes on the following line: --> Reduces msi file size from 102 MB to 94 MB and installation size from 394 MB to 334 MB. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14193) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
UK992 commentedNov 13, 2016
•
edited
Reduces msi file size from 102 MB to 94 MB and installation size from 394 MB to 334 MB.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is