Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Debug for CookieStorage. #14208

Merged
merged 1 commit into from Nov 22, 2016
Merged

Derive Debug for CookieStorage. #14208

merged 1 commit into from Nov 22, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 14, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Derive Debug for CookieStorage.
Loading status checks…
9e8dd86
@highfive
Copy link

highfive commented Nov 14, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/cookie_storage.rs
@highfive
Copy link

highfive commented Nov 14, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Nov 14, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2016

📌 Commit 9e8dd86 has been approved by jdm
@highfive highfive assigned jdm and unassigned SimonSapin Nov 14, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2016

⌛ Testing commit 9e8dd86 with merge 23206c5...
bors-servo added a commit that referenced this pull request Nov 15, 2016
@bors-servo
Auto merge of #14208 - servo:CookieStorage-debug, r=jdm
Loading status checks…
23206c5 
Derive Debug for CookieStorage.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Nov 15, 2016 

  ▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  └   → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a
/_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 15, 2016

@bors-servo retry #10473
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2016

⌛ Testing commit 9e8dd86 with merge 806eab4...
bors-servo added a commit that referenced this pull request Nov 15, 2016
@bors-servo
Auto merge of #14208 - servo:CookieStorage-debug, r=jdm
Loading status checks…
806eab4 
Derive Debug for CookieStorage.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2016

💔 Test failed - mac-rel-wpt1
@highfive
Copy link

highfive commented Nov 15, 2016 

  ▶ TIMEOUT [expected OK] /2dcontext/the-canvas-state/2d.state.saverestore.miterLimit.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ Unexpected subtest result in /2dcontext/the-canvas-state/2d.state.saverestore.miterLimit.html:
  └ NOTRUN [expected PASS] save()/restore() works for miterLimit

  ▶ TIMEOUT [expected OK] /2dcontext/the-canvas-state/2d.state.saverestore.path.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ Unexpected subtest result in /2dcontext/the-canvas-state/2d.state.saverestore.path.html:
  └ NOTRUN [expected PASS] save()/restore() does not affect the current path

  ▶ TIMEOUT [expected OK] /2dcontext/the-canvas-state/2d.state.saverestore.lineJoin.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ Unexpected subtest result in /2dcontext/the-canvas-state/2d.state.saverestore.lineJoin.html:
  └ NOTRUN [expected PASS] save()/restore() works for lineJoin

  ▶ TIMEOUT [expected OK] /2dcontext/the-canvas-state/2d.state.saverestore.lineWidth.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ Unexpected subtest result in /2dcontext/the-canvas-state/2d.state.saverestore.lineWidth.html:
  └ NOTRUN [expected PASS] save()/restore() works for lineWidth

  ▶ TIMEOUT [expected OK] /2dcontext/the-canvas-state/2d.state.saverestore.shadowColor.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ Unexpected subtest result in /2dcontext/the-canvas-state/2d.state.saverestore.shadowColor.html:
  └ NOTRUN [expected PASS] save()/restore() works for shadowColor
@jdm
Copy link
Member

jdm commented Nov 15, 2016

@bors-servo: retry
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 16, 2016

@bors-servo p=-2
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2016

⌛ Testing commit 9e8dd86 with merge cfcb7bb...
bors-servo added a commit that referenced this pull request Nov 17, 2016
@bors-servo
Auto merge of #14208 - servo:CookieStorage-debug, r=jdm
Loading status checks…
cfcb7bb 
Derive Debug for CookieStorage.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Nov 17, 2016 

  ▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  └   → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a
/_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 18, 2016

@bors-servo retry #10473
@Ms2ger Ms2ger mentioned this pull request Nov 18, 2016
Closed
31 of 31 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

⌛ Testing commit 9e8dd86 with merge aa312e1...
bors-servo added a commit that referenced this pull request Nov 20, 2016
@bors-servo
Auto merge of #14208 - servo:CookieStorage-debug, r=jdm
Loading status checks…
aa312e1 
Derive Debug for CookieStorage.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

💔 Test failed - mac-rel-wpt1
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 20, 2016 •
edited by jdm

@bors-servo retry #14323
@bors-servo
Copy link
Contributor

bors-servo commented Nov 22, 2016

⌛ Testing commit 9e8dd86 with merge 3af2586...
bors-servo added a commit that referenced this pull request Nov 22, 2016
@bors-servo
Auto merge of #14208 - servo:CookieStorage-debug, r=jdm
Loading status checks…
3af2586 
Derive Debug for CookieStorage.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14208)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 22, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 9e8dd86 into master Nov 22, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the CookieStorage-debug branch Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @jdm @bors-servo @SimonSapin
You can’t perform that action at this time.