Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uprule tree: Avoid yet another dumb assertion when dropping the rule tree. #14233
Conversation
highfive
commented
Nov 15, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Nov 15, 2016
|
|
|
Could you copy that comment next to this |
|
@bors-servo r=SimonSapin |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 17, 2016
rule tree: Avoid yet another dumb assertion when dropping the rule tree. <!-- Please describe your changes on the following line: --> There's a comment in the caller (where we do the same) saying why this can assert (if this runs from the rule tree root destructor). This doesn't happen in servo's ci because we gc all the time, but can happen when abruptly shutting down the document. r? @SimonSapin or @heycam or @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14233) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 17, 2016
rule tree: Avoid yet another dumb assertion when dropping the rule tree. <!-- Please describe your changes on the following line: --> There's a comment in the caller (where we do the same) saying why this can assert (if this runs from the rule tree root destructor). This doesn't happen in servo's ci because we gc all the time, but can happen when abruptly shutting down the document. r? @SimonSapin or @heycam or @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14233) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 17, 2016
rule tree: Avoid yet another dumb assertion when dropping the rule tree. <!-- Please describe your changes on the following line: --> There's a comment in the caller (where we do the same) saying why this can assert (if this runs from the rule tree root destructor). This doesn't happen in servo's ci because we gc all the time, but can happen when abruptly shutting down the document. r? @SimonSapin or @heycam or @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14233) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 17, 2016
rule tree: Avoid yet another dumb assertion when dropping the rule tree. <!-- Please describe your changes on the following line: --> There's a comment in the caller (where we do the same) saying why this can assert (if this runs from the rule tree root destructor). This doesn't happen in servo's ci because we gc all the time, but can happen when abruptly shutting down the document. r? @SimonSapin or @heycam or @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14233) <!-- Reviewable:end -->
|
|
|
@bors-servo p=33 |
bors-servo
added a commit
that referenced
this pull request
Nov 17, 2016
rule tree: Avoid yet another dumb assertion when dropping the rule tree. <!-- Please describe your changes on the following line: --> There's a comment in the caller (where we do the same) saying why this can assert (if this runs from the rule tree root destructor). This doesn't happen in servo's ci because we gc all the time, but can happen when abruptly shutting down the document. r? @SimonSapin or @heycam or @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14233) <!-- Reviewable:end -->
|
@bors-servo force |
|
Will try landing this commit as part of #14256. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedNov 15, 2016
•
edited by larsbergstrom
There's a comment in the caller (where we do the same) saying why this can assert (if this runs from the rule tree root destructor).
This doesn't happen in servo's ci because we gc all the time, but can happen when abruptly shutting down the document.
r? @SimonSapin or @heycam or @Manishearth
This change is