Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Exit if pip version is detected to be too old. #14253
Conversation
highfive
commented
Nov 16, 2016
|
Heads up! This PR modifies the following files:
|
|
@campaul @larsbergstrom So it looks like it detects 13.1.0. |
|
The problem I was having with this approach was the minimum required version appears to be different between systems. On my computer, the build would fail with anything older than v14.0.0, but Travis is clearly able to build using v13.1.0. I was operating under the assumption that a specific version of virtualenv always corresponds to a specific version of pip, perhaps that assumption is wrong? |
|
I am thinking it probably makes sense to land this with some version, and we can increase the versions or lower them as we run into people with specific issues. It's easy to add Should we start with 13.1.0 or 14.0.0 and add the upgrade line to travis? I think I'm leaning towards the former and adjusting based on incoming bug reports. |
|
Relevant PR: #14452 |
|
Given #14452, do we still need this? |
|
|
|
I think #14452 and the saltification of bootstrap probably both address these issues. |
metajack commentedNov 16, 2016
•
edited by larsbergstrom
Rebased #11149.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is