Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Exit if pip version is detected to be too old. #14253

Closed
wants to merge 1 commit into from

Conversation

@metajack
Copy link
Contributor

metajack commented Nov 16, 2016

Rebased #11149.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because bootstrapping

This change is Reviewable

@highfive
Copy link

highfive commented Nov 16, 2016

Heads up! This PR modifies the following files:

@metajack
Copy link
Contributor Author

metajack commented Nov 17, 2016

@campaul @larsbergstrom So it looks like it detects 13.1.0.

@metajack metajack force-pushed the metajack:upgrade-pip branch from 5601a3c to 0b9cc84 Nov 17, 2016
@campaul
Copy link
Contributor

campaul commented Nov 17, 2016

The problem I was having with this approach was the minimum required version appears to be different between systems. On my computer, the build would fail with anything older than v14.0.0, but Travis is clearly able to build using v13.1.0.

I was operating under the assumption that a specific version of virtualenv always corresponds to a specific version of pip, perhaps that assumption is wrong?

@metajack metajack force-pushed the metajack:upgrade-pip branch from 0b9cc84 to 251b107 Nov 17, 2016
@metajack
Copy link
Contributor Author

metajack commented Nov 17, 2016

I am thinking it probably makes sense to land this with some version, and we can increase the versions or lower them as we run into people with specific issues. It's easy to add pip install --upgrade pip virtualenv to the travis yaml.

Should we start with 13.1.0 or 14.0.0 and add the upgrade line to travis? I think I'm leaning towards the former and adjusting based on incoming bug reports.

@frewsxcv
Copy link
Member

frewsxcv commented Dec 4, 2016

Relevant PR: #14452

@cbrewster cbrewster assigned frewsxcv and unassigned cbrewster Dec 5, 2016
@jdm
Copy link
Member

jdm commented Jan 19, 2017

Given #14452, do we still need this?

@bors-servo
Copy link
Contributor

bors-servo commented Jan 20, 2017

The latest upstream changes (presumably #14974) made this pull request unmergeable. Please resolve the merge conflicts.

@metajack
Copy link
Contributor Author

metajack commented Jan 31, 2017

I think #14452 and the saltification of bootstrap probably both address these issues.

@metajack metajack closed this Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.