Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cargo paths for the python script #14266

Merged
merged 1 commit into from Nov 18, 2016
Merged

Updated cargo paths for the python script #14266

merged 1 commit into from Nov 18, 2016

Conversation

@kvark
Copy link
Member

kvark commented Nov 17, 2016 •
edited by larsbergstrom

Related to #14172

Needed this for ./mach cargo-update -p webrender to work properly when replacing with a local copy

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because it's not adding any new logic

This change is Reviewable
@kvark
Updated cargo paths for the python script
Loading status checks…
f43c285 
Related to #14172

Needed this for `./mach cargo-update -p webrender` to work properly when replacing with a local copy
@highfive
Copy link

highfive commented Nov 17, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @connorgbrewster (or someone else) soon.
@highfive
Copy link

highfive commented Nov 17, 2016

Heads up! This PR modifies the following files:
@metajack
Copy link
Contributor

metajack commented Nov 17, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2016

📌 Commit f43c285 has been approved by metajack
@highfive highfive assigned metajack and unassigned cbrewster Nov 17, 2016
@glennw
Copy link
Member

glennw commented Nov 18, 2016

@bors-servo p=10
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2016

⌛ Testing commit f43c285 with merge cc06363...
bors-servo added a commit that referenced this pull request Nov 18, 2016
@bors-servo
Auto merge of #14266 - servo:kvark-cargo, r=metajack
Loading status checks…
cc06363 
Updated cargo paths for the python script

<!-- Please describe your changes on the following line: -->
Related to #14172

Needed this for `./mach cargo-update -p webrender` to work properly when replacing with a local copy

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it's not adding any new logic

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14266)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Nov 18, 2016 

  ▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  └   → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a
/_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
@nox
Copy link
Member

nox commented Nov 18, 2016

@bors-servo retry #10473 p=1023
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2016

💔 Test failed - linux-rel-wpt
@nox
Copy link
Member

nox commented Nov 18, 2016

@bors-servo retry #10473
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit f43c285 into master Nov 18, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the kvark-cargo branch Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@kvark @highfive @metajack @bors-servo @glennw @nox @cbrewster
You can’t perform that action at this time.