Regenerate bindings #14268

Manishearth · 2016-11-18T01:51:06Z

Don't merge yet

This change is


        Regenerate bindings

highfive · 2016-11-18T01:51:10Z

Heads up! This PR modifies the following files:

@bholley: components/style/gecko_bindings/structs_debug.rs, components/style/gecko_string_cache/atom_macro.rs, components/style/gecko_bindings/structs_release.rs
@emilio: components/style/gecko_bindings/structs_debug.rs, components/style/gecko_string_cache/atom_macro.rs, components/style/gecko_bindings/structs_release.rs

highfive · 2016-11-18T01:51:11Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify style code, but no tests are modified. Please consider adding a test!

Manishearth · 2016-11-18T03:29:57Z

I'm getting this segfault on wikipedia:

thread '<unnamed>' panicked at 'Calling previous_styles without having gathered it', /Users/manishearth/mozilla/s-i/servo/components/style/data.rs:172
stack backtrace:
   1:        0x114b01138 - std::sys::backtrace::tracing::imp::write::h22f199c1dbb72ba2
   2:        0x114b0eacf - std::panicking::default_hook::{{closure}}::h9a389c462b6a22dd
   3:        0x114b0bf9f - std::panicking::default_hook::h852b4223c1c00c59
   4:        0x114b0c5c6 - std::panicking::rust_panic_with_hook::hcd9d05f53fa0dafc
   5:        0x1147af61a - std::panicking::begin_panic::hc03e2830c2c89a5f
   6:        0x11487c01a - style::data::ElementData::previous_styles_mut::h3209ac372e2e86dd
   7:        0x11488af2d - style::matching::MatchMethods::cascade_node::hc5639905206ebb4b
   8:        0x114892dba - style::traversal::recalc_style_at::h0e01fc41d4f2f294
   9:        0x11487dc79 - <style::gecko::traversal::RecalcStyleOnly<'lc> as style::traversal::DomTraversalContext<style::gecko::wrapper::GeckoNode<'ln>>>::process_preorder::ha33cdaf57d18a3a9
  10:        0x1146f71b1 - style::parallel::top_down_dom::{{closure}}::h5d9a5fa5b76c3f58
  11:        0x1146f70c3 - rayon::scope::Scope::execute_job_closure::{{closure}}::h1f98fccacfa09a33
  12:        0x1146ec797 - <std::panic::AssertUnwindSafe<F> as core::ops::FnOnce<()>>::call_once::h415c352b9b94e4d7
  13:        0x114693a67 - std::panicking::try::do_call::h3f93514d15f1526b

Trypush at https://treeherder.mozilla.org/#/jobs?repo=try&revision=dee8796be7b8a0b9811c683bf3b5079bc5019af0&selectedJob=31377430

@bholley , know anything about this? Seems to be related to your cascade changes?

wafflespeanut · 2016-11-18T09:19:36Z

Note: There's another #14255

bholley · 2016-11-18T22:14:29Z

@bors-servo delegate+

bors-servo · 2016-11-18T22:14:30Z

✌️ @Manishearth can now approve this pull request

Manishearth · 2016-11-18T22:20:12Z

@bors-servo r=bholley

bors-servo · 2016-11-18T22:20:14Z

📌 Commit 1c35faf has been approved by bholley

bors-servo · 2016-11-19T05:20:46Z

⌛ Testing commit 1c35faf with merge 51d9ef9...


        Auto merge of #14268 - Manishearth:regen, r=bholley

Regenerate bindings Don't merge yet  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14268)

bors-servo · 2016-11-19T05:40:19Z

💔 Test failed - linux-dev


        Uplift bitfield fix for nsChangeHint

Manishearth · 2016-11-19T05:45:23Z

@bors-servo r=bholley

bors-servo · 2016-11-19T05:45:24Z

📌 Commit 3d5b26a has been approved by bholley

bors-servo · 2016-11-19T06:55:34Z

⌛ Testing commit 3d5b26a with merge 41d0d01...

bors-servo · 2016-11-20T17:36:15Z

⌛ Testing commit 3d5b26a with merge 8c60848...


        Auto merge of #14268 - Manishearth:regen, r=bholley

Regenerate bindings Don't merge yet  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14268)

bors-servo · 2016-11-20T18:35:12Z

💔 Test failed - linux-rel-wpt

KiChjang · 2016-11-20T21:06:49Z

@bors-servo retry

#14247

bors-servo · 2016-11-20T22:08:29Z

⌛ Testing commit 3d5b26a with merge 5de74cc...


        Auto merge of #14268 - Manishearth:regen, r=bholley

Regenerate bindings Don't merge yet  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14268)

bors-servo · 2016-11-20T23:05:58Z

💔 Test failed - mac-rel-wpt1

KiChjang · 2016-11-21T01:37:54Z

@bors-servo retry

#13133

heycam · 2016-11-21T03:59:12Z

@bors-servo p=1

heycam · 2016-11-21T03:59:37Z

@bors-servo p=0

bors-servo · 2016-11-21T18:19:40Z

⌛ Testing commit 3d5b26a with merge 95bc7ec...


        Auto merge of #14268 - Manishearth:regen, r=bholley

Regenerate bindings Don't merge yet  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14268)

bors-servo · 2016-11-21T19:10:46Z

💔 Test failed - mac-rel-wpt1

Manishearth · 2016-11-21T19:17:34Z

@bors-servo retry

#14267

bors-servo · 2016-11-21T20:00:35Z

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-dev are reusable. Rebuilding only mac-rel-wpt1...

bors-servo · 2016-11-21T20:52:00Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

Regenerate bindings

Loading status checks…

9fb589d

highfive assigned emilio Nov 18, 2016

highfive added the S-awaiting-review label Nov 18, 2016

highfive assigned bholley and unassigned emilio Nov 18, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 18, 2016

Manishearth mentioned this pull request Nov 18, 2016

Regenerate bindings. #14255

Closed

0 of 5 tasks complete

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 19, 2016

Uplift bitfield fix for nsChangeHint

Loading status checks…

3d5b26a

Manishearth force-pushed the Manishearth:regen branch from 1c35faf to 3d5b26a Nov 19, 2016

highfive added S-awaiting-review and removed S-tests-failed labels Nov 19, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 19, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Nov 20, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 20, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Nov 20, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 20, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Nov 21, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 21, 2016

bors-servo merged commit 3d5b26a into servo:master Nov 21, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

bors-servo mentioned this pull request Nov 21, 2016

stylo: Basic infrastructure for RestyleHint-driven traversal #14300

Merged

servo / servo

Regenerate bindings #14268

Regenerate bindings #14268

Manishearth commented Nov 18, 2016 •

edited by larsbergstrom

highfive commented Nov 18, 2016

highfive commented Nov 18, 2016

Manishearth commented Nov 18, 2016

wafflespeanut commented Nov 18, 2016

bholley commented Nov 18, 2016

bors-servo commented Nov 18, 2016

Manishearth commented Nov 18, 2016

bors-servo commented Nov 18, 2016

bors-servo commented Nov 19, 2016

bors-servo commented Nov 19, 2016

Manishearth commented Nov 19, 2016

bors-servo commented Nov 19, 2016

bors-servo commented Nov 19, 2016

bors-servo commented Nov 20, 2016

bors-servo commented Nov 20, 2016

KiChjang commented Nov 20, 2016

bors-servo commented Nov 20, 2016

bors-servo commented Nov 20, 2016

KiChjang commented Nov 21, 2016

heycam commented Nov 21, 2016

heycam commented Nov 21, 2016

bors-servo commented Nov 21, 2016

bors-servo commented Nov 21, 2016

Manishearth commented Nov 21, 2016

bors-servo commented Nov 21, 2016

bors-servo commented Nov 21, 2016

servo / servo

Join GitHub today

Regenerate bindings #14268

Regenerate bindings #14268

Conversation

Manishearth commented Nov 18, 2016 • edited by larsbergstrom

highfive commented Nov 18, 2016

highfive commented Nov 18, 2016

Manishearth commented Nov 18, 2016

wafflespeanut commented Nov 18, 2016

bholley commented Nov 18, 2016

bors-servo commented Nov 18, 2016

Manishearth commented Nov 18, 2016

bors-servo commented Nov 18, 2016

bors-servo commented Nov 19, 2016

bors-servo commented Nov 19, 2016

Manishearth commented Nov 19, 2016

bors-servo commented Nov 19, 2016

bors-servo commented Nov 19, 2016

bors-servo commented Nov 20, 2016

bors-servo commented Nov 20, 2016

KiChjang commented Nov 20, 2016

bors-servo commented Nov 20, 2016

bors-servo commented Nov 20, 2016

KiChjang commented Nov 21, 2016

heycam commented Nov 21, 2016

heycam commented Nov 21, 2016

bors-servo commented Nov 21, 2016

bors-servo commented Nov 21, 2016

Manishearth commented Nov 21, 2016

bors-servo commented Nov 21, 2016

bors-servo commented Nov 21, 2016

Manishearth commented Nov 18, 2016 •

edited by larsbergstrom