Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement range index with the Position enum on ServoUrl #14274

Merged
merged 1 commit into from Nov 20, 2016
Merged

Implement range index with the Position enum on ServoUrl #14274

merged 1 commit into from Nov 20, 2016

Conversation

@stshine
Copy link
Contributor

stshine commented Nov 18, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because refactoring

r? @emilio

This change is Reviewable
@stshine
Implement range index with the Position enum on ServoUrl
Loading status checks…
0818b44
@highfive
Copy link

highfive commented Nov 18, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/xmlhttprequest.rs, components/script/script_thread.rs, components/script/dom/response.rs
  • @KiChjang: components/net/http_loader.rs, components/net/data_loader.rs, components/script/dom/xmlhttprequest.rs, components/script/script_thread.rs, components/script/dom/response.rs
@highfive
Copy link

highfive commented Nov 18, 2016

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Nov 18, 2016

So the idea is that this might eventually be not supported when we add a data variant that bypasses rust-url, but we can do that when needed I guess, and it's less easy to forget to change them when needed.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2016

📌 Commit 0818b44 has been approved by emilio
@stshine
Copy link
Contributor Author

stshine commented Nov 18, 2016 •
edited

Tried to take a look at the data uri thing, and since data uri can encode a complete html document, in case for url related spec to work properly, at least we should have proper query part and fragment part. So despite the actual implementation, we may have hope on that the index traits may still be useful for data uri; and if not, like what is said, it may not be hard to remove them :)
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

⌛ Testing commit 0818b44 with merge a2d0dad...
bors-servo added a commit that referenced this pull request Nov 20, 2016
@bors-servo
Auto merge of #14274 - stshine:servo-url-index, r=emilio
Loading status checks…
a2d0dad 
Implement range index with the Position enum on ServoUrl

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14274)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

💔 Test failed - mac-rel-wpt1
@stshine
Copy link
Contributor Author

stshine commented Nov 20, 2016

@bors-servo retry
#11100
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-dev are reusable. Rebuilding only mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented Nov 20, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

⌛ Testing commit 0818b44 with merge ac6a268...
bors-servo added a commit that referenced this pull request Nov 20, 2016
@bors-servo
Auto merge of #14274 - stshine:servo-url-index, r=emilio
Loading status checks…
ac6a268 
Implement range index with the Position enum on ServoUrl

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14274)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 0818b44 into servo:master Nov 20, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@stshine stshine deleted the stshine:servo-url-index branch Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@stshine @highfive @emilio @bors-servo @jdm
You can’t perform that action at this time.