Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo doc in the ports/servo directory #14281

Merged
merged 1 commit into from Nov 20, 2016
Merged

Run cargo doc in the ports/servo directory #14281

merged 1 commit into from Nov 20, 2016

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Nov 18, 2016 •
edited by larsbergstrom

Running it in components/servo isn't guaranteed to work because there's no Cargo.lock checked in there. Followup to #14254.

This change is Reviewable
@mbrubeck
Run cargo doc in the ports/servo directory
Loading status checks…
02f1890 
Running it in components/servo isn't guaranteed to work because there's
no Cargo.lock checked in there.  Followup to #14254.
@highfive
Copy link

highfive commented Nov 18, 2016

Heads up! This PR modifies the following files:
@Manishearth
Copy link
Member

Manishearth commented Nov 18, 2016

@bors-servo r+
@highfive highfive assigned Manishearth and unassigned cbrewster Nov 18, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2016

📌 Commit 02f1890 has been approved by Manishearth
@Manishearth
Copy link
Member

Manishearth commented Nov 19, 2016

@bors-servo p=100
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

⌛ Testing commit 02f1890 with merge 73cbe61...
bors-servo added a commit that referenced this pull request Nov 19, 2016
@bors-servo
Auto merge of #14281 - mbrubeck:mach-doc-fix, r=Manishearth
Loading status checks…
73cbe61 
Run cargo doc in the ports/servo directory

Running it in components/servo isn't guaranteed to work because there's no Cargo.lock checked in there.  Followup to #14254.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14281)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Nov 19, 2016 

  ▶ FAIL [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  └   → /_mozilla/css/incremental_trailing_whitespace_a.html da54041086f2975f8e3c776d2283ad6609e6862a
/_mozilla/css/incremental_trailing_whitespace_ref.html f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
Testing da54041086f2975f8e3c776d2283ad6609e6862a == f5d0147c8bddbdc772a7e5e86c7c9e433fcd486b
@Manishearth
Copy link
Member

Manishearth commented Nov 19, 2016 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 02f1890 into servo:master Nov 20, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:mach-doc-fix branch May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mbrubeck @highfive @Manishearth @bors-servo @cbrewster
You can’t perform that action at this time.