Try to fix incremental_trailing_whitespace_a.html#14285
Closed
emilio wants to merge 2 commits intoservo:masterfrom
Closed
Try to fix incremental_trailing_whitespace_a.html#14285emilio wants to merge 2 commits intoservo:masterfrom
emilio wants to merge 2 commits intoservo:masterfrom
Conversation
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
Member
Author
|
@bors-servo try |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Nov 19, 2016
Try to fix incremental_trailing_whitespace_a.html <!-- Please describe your changes on the following line: --> This includes w3c/wptrunner#219
Contributor
|
Drop the wptrunner change, please. |
Contributor
|
💔 Test failed - mac-rel-wpt2 |
|
Member
Author
|
On Sat, Nov 19, 2016 at 06:50:01AM -0800, Servo Greeter wrote:
That's success... :( |
…e image. The ready state could depend on animations being processed (as in incremental_trailing_whitespace_a.html), and that will never happen with the previous code.
Member
Author
|
Ok, the compositor wasn't processing animations in the case the image output was not stable, which was why this test was timing out permanently. Let's see how the infra looks like with the last patch. @bors-servo try |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Nov 19, 2016
Try to fix incremental_trailing_whitespace_a.html <!-- Please describe your changes on the following line: --> This includes w3c/wptrunner#219 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14285) <!-- Reviewable:end -->
Member
Author
|
I bet now it's going to perma-fail in automation because of #13865... |
Contributor
|
💔 Test failed - mac-rel-wpt2 |
|
Member
|
What do you want to do with this PR, @emilio? |
Member
Author
|
This would need more work. The way we decide how to take a screenshot in presence of animations is dubious, but this is not the correct fix for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes w3c/wptrunner#219
This change is