Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTry to fix incremental_trailing_whitespace_a.html #14285
Conversation
This includes w3c/wptrunner#219
highfive
commented
Nov 19, 2016
|
Heads up! This PR modifies the following files:
|
|
@bors-servo try |
Try to fix incremental_trailing_whitespace_a.html <!-- Please describe your changes on the following line: --> This includes w3c/wptrunner#219
|
Drop the wptrunner change, please. |
|
|
highfive
commented
Nov 19, 2016
|
|
On Sat, Nov 19, 2016 at 06:50:01AM -0800, Servo Greeter wrote:
That's success... :( |
…e image. The ready state could depend on animations being processed (as in incremental_trailing_whitespace_a.html), and that will never happen with the previous code.
|
Ok, the compositor wasn't processing animations in the case the image output was not stable, which was why this test was timing out permanently. Let's see how the infra looks like with the last patch. @bors-servo try |
Try to fix incremental_trailing_whitespace_a.html <!-- Please describe your changes on the following line: --> This includes w3c/wptrunner#219 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14285) <!-- Reviewable:end -->
|
I bet now it's going to perma-fail in automation because of #13865... |
|
|
highfive
commented
Nov 19, 2016
|
|
What do you want to do with this PR, @emilio? |
|
This would need more work. The way we decide how to take a screenshot in presence of animations is dubious, but this is not the correct fix for that. |
emilio commentedNov 19, 2016
•
edited by larsbergstrom
This includes w3c/wptrunner#219
This change is