Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix incremental_trailing_whitespace_a.html #14285

Closed
wants to merge 2 commits into from
Closed

Try to fix incremental_trailing_whitespace_a.html #14285

wants to merge 2 commits into from
+22 −8

Conversation

@emilio
Copy link
Member

emilio commented Nov 19, 2016 •
edited by larsbergstrom

This includes w3c/wptrunner#219

This change is Reviewable
@emilio
Try to fix incremental_trailing_whitespace_a.html
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
cfca049 
This includes w3c/wptrunner#219
@highfive
Copy link

highfive commented Nov 19, 2016

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/harness/wptrunner/executors/reftest-wait_servodriver.js
@emilio
Copy link
Member Author

emilio commented Nov 19, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

⌛ Trying commit cfca049 with merge 96e9961...
bors-servo added a commit that referenced this pull request Nov 19, 2016
@bors-servo
Auto merge of #14285 - emilio:incremental, r=<try>
Loading status checks…
96e9961 
Try to fix incremental_trailing_whitespace_a.html

<!-- Please describe your changes on the following line: -->

This includes w3c/wptrunner#219
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 19, 2016

Drop the wptrunner change, please.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

💔 Test failed - mac-rel-wpt2
@highfive
Copy link

highfive commented Nov 19, 2016 

  ▶ TIMEOUT [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1
@emilio
Copy link
Member Author

emilio commented Nov 19, 2016

On Sat, Nov 19, 2016 at 06:50:01AM -0800, Servo Greeter wrote:

  ▶ TIMEOUT [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

That's success... :(
@emilio
compositor: Process animations before asking the constellation for th…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
d6dc6d8 
…e image.

The ready state could depend on animations being processed (as in
incremental_trailing_whitespace_a.html), and that will never happen with the
previous code.
@emilio
Copy link
Member Author

emilio commented Nov 19, 2016

Ok, the compositor wasn't processing animations in the case the image output was not stable, which was why this test was timing out permanently. Let's see how the infra looks like with the last patch.

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

⌛ Trying commit d6dc6d8 with merge 153c88f...
bors-servo added a commit that referenced this pull request Nov 19, 2016
@bors-servo
Auto merge of #14285 - emilio:incremental, r=<try>
Loading status checks…
153c88f 
Try to fix incremental_trailing_whitespace_a.html

<!-- Please describe your changes on the following line: -->

This includes w3c/wptrunner#219

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14285)
<!-- Reviewable:end -->
@emilio
Copy link
Member Author

emilio commented Nov 19, 2016

I bet now it's going to perma-fail in automation because of #13865...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2016

💔 Test failed - mac-rel-wpt2
@highfive
Copy link

highfive commented Nov 19, 2016 

  ▶ TIMEOUT [expected PASS] /_mozilla/css/incremental_trailing_whitespace_a.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ TIMEOUT [expected PASS] /_mozilla/css/rotate_anim.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ TIMEOUT [expected PASS] /_mozilla/css/transition_calc.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ TIMEOUT [expected PASS] /_mozilla/css/transition_calc_implicit.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1
@jdm
Copy link
Member

jdm commented Dec 15, 2016

What do you want to do with this PR, @emilio?
@emilio
Copy link
Member Author

emilio commented Dec 15, 2016

This would need more work. The way we decide how to take a screenshot in presence of animations is dubious, but this is not the correct fix for that.
@emilio emilio closed this Dec 15, 2016
@emilio emilio deleted the emilio:incremental branch Dec 15, 2016
@emilio emilio mentioned this pull request Feb 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
S-awaiting-review S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @bors-servo @Ms2ger @jdm @larsbergstrom
You can’t perform that action at this time.