Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a few source files #14294

Merged
merged 2 commits into from Nov 20, 2016
Merged

Rename a few source files #14294

merged 2 commits into from Nov 20, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 20, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
SimonSapin added 2 commits Nov 20, 2016
@SimonSapin
Rename selector_matching.rs to stylist.rs
0806680
@SimonSapin
Rename selector_impl.rs to selector_parser.rs
Loading status checks…
b203ab2 
This makes it consistent with an upcoming update of the selectors crate.
@highfive
Copy link

highfive commented Nov 20, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/selector_matching.rs, components/style/data.rs, components/style/servo/selector_parser.rs, components/style/selector_parser.rs, components/style/matching.rs, components/style/lib.rs, components/style/servo/mod.rs, components/style/gecko/snapshot.rs, components/style/stylist.rs, components/style/gecko/data.rs, components/style/restyle_hints.rs, components/style/parser.rs, components/style/gecko/mod.rs, components/style/dom.rs, components/style/gecko/wrapper.rs, components/style/context.rs, components/style/stylesheets.rs, components/style/gecko/selector_parser.rs, components/style/servo/selector_impl.rs, components/style/gecko/selector_impl.rs, components/style/selector_impl.rs
  • @KiChjang: components/script/dom/window.rs, components/script/dom/document.rs, components/script/dom/cssstyledeclaration.rs, components/script/dom/element.rs, components/script_layout_interface/lib.rs, components/script_layout_interface/message.rs, components/script/dom/node.rs, components/script/layout_wrapper.rs, components/script_layout_interface/wrapper_traits.rs, components/script/dom/bindings/trace.rs
  • @fitzgen: components/script/dom/window.rs, components/script/dom/document.rs, components/script/dom/cssstyledeclaration.rs, components/script/dom/element.rs, components/script_layout_interface/lib.rs, components/script_layout_interface/message.rs, components/script/dom/node.rs, components/script/layout_wrapper.rs, components/script_layout_interface/wrapper_traits.rs, components/script/dom/bindings/trace.rs
  • @emilio: components/style/selector_matching.rs, ports/geckolib/glue.rs, components/style/data.rs, components/style/servo/selector_parser.rs, components/layout/animation.rs, components/style/selector_parser.rs, components/style/matching.rs, components/style/lib.rs, components/layout/incremental.rs, components/style/servo/mod.rs, components/layout/flow.rs, components/style/gecko/snapshot.rs, components/style/stylist.rs, components/style/gecko/data.rs, components/layout/traversal.rs, components/style/restyle_hints.rs, components/style/parser.rs, components/style/gecko/mod.rs, components/layout/construct.rs, components/style/dom.rs, components/style/gecko/wrapper.rs, components/style/context.rs, components/layout/fragment.rs, components/style/stylesheets.rs, components/layout/generated_content.rs, components/style/gecko/selector_parser.rs, components/style/servo/selector_impl.rs, components/style/gecko/selector_impl.rs, components/layout/query.rs, components/style/selector_impl.rs
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 20, 2016

@bors-servo p=1000
@wafflespeanut
Copy link
Member

wafflespeanut commented Nov 20, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

📌 Commit b203ab2 has been approved by Wafflespeanut
@highfive highfive assigned wafflespeanut and unassigned asajeffrey Nov 20, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

⌛ Testing commit b203ab2 with merge 68b1d1d...
bors-servo added a commit that referenced this pull request Nov 20, 2016
@bors-servo
Auto merge of #14294 - servo:renames, r=Wafflespeanut
Loading status checks…
68b1d1d 
Rename a few source files

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14294)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Nov 20, 2016 

  ▶ TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling.html:
  └ NOTRUN [expected FAIL] Test that javascript: evaluation only performs a navigation to the\n  result when the result is a string value.
@emilio
Copy link
Member

emilio commented Nov 20, 2016

@bors-servo retry

Nice cleanup btw :)
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit b203ab2 into master Nov 20, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 20, 2016
Merged
@SimonSapin SimonSapin deleted the renames branch Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @wafflespeanut @bors-servo @emilio @asajeffrey
You can’t perform that action at this time.