Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Basic infrastructure for RestyleHint-driven traversal #14300

Merged
merged 3 commits into from Nov 25, 2016
Merged

stylo: Basic infrastructure for RestyleHint-driven traversal #14300

merged 3 commits into from Nov 25, 2016
+1,446 −888

Commits on Nov 25, 2016

  1. Bug 1317016 - Basic infrastructure for RestyleHint-driven traversal. 

    MozReview-Commit-ID: 7wH5XcILVmX
    @bholley
    bholley committed Nov 25, 2016
    992f7dd

  2. Revert restyled_previous_sibling_element tracking, and separate child… 

    … preprocessing.

I realized that I fixed this issue incorrectly when the test failed before. Our design
document specifies that restyle hints must be expanded by the parent before traversing
children, so that we can properly apply LaterSiblings restyle hints. This includes
parents that do not themselves need processing (StylingMode::Traverse).

So we need to preprocess children even in the case where we don't restyle the parent.
On the flip side, we do in fact know whether a child needs processing before enqueuing
it, so we can skip the conservative visit I added before.

MozReview-Commit-ID: AEiRzdsN0h5
    @bholley
    bholley committed Nov 25, 2016
    Loading status checks…
    e65b1be

  3. Disable pseudo-elements-001.htm.ini for too many intermittent failures. 

    This seems to be failing more now on several distinct PRs.
    @bholley
    bholley committed Nov 25, 2016
    Loading status checks…
    900ad11
You can’t perform that action at this time.