New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement discarding Document objects to reclaim space. #14312
Merged
+307
−219
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
78c87ea
Implement discarding Document objects to reclaim space.
asajeffrey 67bf230
Added warnings for idempotent freeze/thaw.
asajeffrey ef50a64
Updated comment.
asajeffrey 1a201fc
Pass test-tidy.
asajeffrey c14c431
Default --max-session-history is now 16.
asajeffrey File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
Added warnings for idempotent freeze/thaw.
- Loading branch information
commit 67bf23016e48f6aab7c3c5556a86226783a8c55d
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
While I think making freeze/thaw/suspend idempotent isn't a bad idea, I think it can let some issues fall through the cracks. For example #13716 is caused by a some Pipelines not being frozen when navigated from. We would have no idea that this was happening if suspend was idempotent. At a minimum, it might be nice to add a
warn!when returning early here and inresume