Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite and remove most unit tests for the legacy fetch stack. #14315

Merged
merged 14 commits into from Nov 24, 2016
Merged

Rewrite and remove most unit tests for the legacy fetch stack. #14315

merged 14 commits into from Nov 24, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 22, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Nov 22, 2016

Heads up! This PR modifies the following files:
@Ms2ger Ms2ger mentioned this pull request Nov 22, 2016
Closed
31 of 31 tasks complete
@Manishearth
Manishearth approved these changes Nov 22, 2016
View changes
Copy link
Member

Manishearth left a comment

r=me

Regarding 9a4322b , could you elaborate about the security model? Is there a bug we should file here?
@jdm
Copy link
Member

jdm commented Nov 22, 2016

@Ms2ger I think I'd like either the test in 9a4322b rewritten to use host replacement or replaced by a WPT test.
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 23, 2016

I tried to write a wpt test at Ms2ger@addfba6 , but failed... There's a CORS check rejecting my last fetch.
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 23, 2016

#14345
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2016

☔ The latest upstream changes (presumably #14345) made this pull request unmergeable. Please resolve the merge conflicts.
Ms2ger added 14 commits Nov 14, 2016
@Ms2ger
Rewrite test_load_follows_a_redirect.
27d90fb
@Ms2ger
Rewrite test_if_auth_creds_not_in_url_but_in_cache_it_sets_it.
9f23949
@Ms2ger
Remove test_auth_ui_sets_header_on_401.
4c34e9a 
The fetch stack does not yet support asking the user for credentials (#14305).
@Ms2ger
Rewrite test_auth_ui_needs_www_auth.
a8f7f3c
@Ms2ger
Remove referrer policy unit tests.
64d176d 
This code should be covered sufficiently by wpt tests.
@Ms2ger
Remove test for CustomResponseMediator.
3da075c 
The fetch stack does not yet support this at all (#14306).
@Ms2ger
Split test_content_blocked for readability.
b4178c7
@Ms2ger
Rewrite test_content_blocked.
2fa0321
@Ms2ger
Rewrite test_cookies_blocked.
ce89fcf
@Ms2ger
Translate a unit test for bogus schemes to fetch.
fc26aaf
@Ms2ger
Translate a test for ftp URLs to fetch.
621ca61
@Ms2ger
Remove a test for view-source.
adc78c7 
This scheme is not currently supported in fetch (#14308).
@Ms2ger
Remove references to https from http_loader unit tests.
f4f1258
@Ms2ger
Rewrite test_redirect_from_x_to_x_provides_x_with_cookie_from_first_r…
Loading status checks…
2dc73d8 
…esponse.
@Ms2ger Ms2ger force-pushed the fetch-unit-http branch from 8641cec to 2dc73d8 Nov 23, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 23, 2016

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2016

📌 Commit 2dc73d8 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2016

⌛ Testing commit 2dc73d8 with merge c0c6173...
bors-servo added a commit that referenced this pull request Nov 23, 2016
@bors-servo
Auto merge of #14315 - servo:fetch-unit-http, r=Manishearth
Loading status checks…
c0c6173 
Rewrite and remove most unit tests for the legacy fetch stack.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14315)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2016

💔 Test failed - linux-rel-wpt
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 23, 2016

@bors-servo retry # #14323
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

💔 Test failed - linux-rel-wpt
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 24, 2016

@bors-servo retry #14337 #13776 #14221
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

⌛ Testing commit 2dc73d8 with merge 5bfe1de...
bors-servo added a commit that referenced this pull request Nov 24, 2016
@bors-servo
Auto merge of #14315 - servo:fetch-unit-http, r=Manishearth
Loading status checks…
5bfe1de 
Rewrite and remove most unit tests for the legacy fetch stack.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14315)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 2dc73d8 into master Nov 24, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the fetch-unit-http branch Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @jdm @bors-servo @Manishearth
You can’t perform that action at this time.