Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement access to CSSStyleRule for stylo #14330

Merged
merged 5 commits into from Nov 24, 2016
Merged

Implement access to CSSStyleRule for stylo #14330

merged 5 commits into from Nov 24, 2016

Conversation

@upsuper
Copy link
Member

upsuper commented Nov 22, 2016 •
edited by larsbergstrom

This is the servo part of bug 1307357 which has been reviewed by @heycam, @Manishearth and @SimonSapin.

r? @heycam

(./mach test-tidy reports several issues on bindings.rs... which I don't think is introduced by my patch... so I have no idea what to do here...)

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Nov 22, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/stylesheets.rs, components/style/gecko/conversions.rs, components/style/binding_tools/regen.py
  • @emilio: components/style/gecko_bindings/bindings.rs, ports/geckolib/glue.rs, components/style/stylesheets.rs, components/style/gecko/conversions.rs, components/style/binding_tools/regen.py
@highfive
Copy link

highfive commented Nov 22, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper
Copy link
Member Author

upsuper commented Nov 23, 2016

It seems although ./mach test-tidy complains, ./mach test-tidy --all doesn't.
@upsuper
Copy link
Member Author

upsuper commented Nov 23, 2016

It seems bindings.rs is not synced properly... Fixing...
@upsuper upsuper force-pushed the upsuper-forks:bug1307357 branch 2 times, most recently from 48e2b04 to 1a5d4ee Nov 23, 2016
@heycam
Copy link
Member

heycam commented Nov 23, 2016

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2016

✌️ @upsuper can now approve this pull request
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2016

☔ The latest upstream changes (presumably #14241) made this pull request unmergeable. Please resolve the merge conflicts.
upsuper added 5 commits Nov 22, 2016
@upsuper
Add stylo FFI for CSSRuleList
9d4ab0d
@upsuper
Add stylo FFI for CSSStyleRule
a9296bc
@upsuper
Add stylo FFI for cssText getters of CSSStyleRule
66669e4
@upsuper
Add stylo FFI for CSSStyleRule.style
9ee2ec5
@upsuper
Add FFI for debug info of CSSStyleRule
Loading status checks…
3c5871f
@upsuper upsuper force-pushed the upsuper-forks:bug1307357 branch from 1a5d4ee to 3c5871f Nov 23, 2016
@upsuper
Copy link
Member Author

upsuper commented Nov 23, 2016

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2016

📌 Commit 3c5871f has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented Nov 23, 2016

⌛ Testing commit 3c5871f with merge c8e39dc...
bors-servo added a commit that referenced this pull request Nov 23, 2016
@bors-servo
Auto merge of #14330 - upsuper:bug1307357, r=heycam
Loading status checks…
c8e39dc 
Implement access to CSSStyleRule for stylo

<!-- Please describe your changes on the following line: -->
This is the servo part of [bug 1307357](https://bugzilla.mozilla.org/show_bug.cgi?id=1307357) which has been reviewed by @heycam, @Manishearth and @SimonSapin.

r? @heycam

(`./mach test-tidy` reports several issues on bindings.rs... which I don't think is introduced by my patch... so I have no idea what to do here...)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14330)
<!-- Reviewable:end -->
@Manishearth Manishearth mentioned this pull request Nov 24, 2016
Closed
@Manishearth
Copy link
Member

Manishearth commented Nov 24, 2016

@bors-servo p=10
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Nov 24, 2016 

  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_after_load.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1
@bholley
Copy link
Contributor

bholley commented Nov 24, 2016

@bors-servo retry
@bholley
Copy link
Contributor

bholley commented Nov 24, 2016

#14337
@bholley
Copy link
Contributor

bholley commented Nov 24, 2016

@bors-servo r-
@bholley
Copy link
Contributor

bholley commented Nov 24, 2016

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

📌 Commit 3c5871f has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

💔 Test failed - linux-rel-wpt
@highfive
Copy link

highfive commented Nov 24, 2016 

  ▶ Unexpected subtest result in /html/webappapis/scripting/event-loops/microtask_after_script.html:
  └ PASS [expected FAIL] Microtask immediately after script
@upsuper
Copy link
Member Author

upsuper commented Nov 24, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

💔 Test failed - linux-rel-wpt
@upsuper
Copy link
Member Author

upsuper commented Nov 24, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 3c5871f into servo:master Nov 24, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 24, 2016
Merged
2 of 5 tasks complete
@upsuper upsuper deleted the upsuper-forks:bug1307357 branch Nov 24, 2016
@bors-servo bors-servo mentioned this pull request Nov 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@upsuper @highfive @heycam @bors-servo @Manishearth @bholley
You can’t perform that action at this time.