Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regen bindings #14354

Closed
wants to merge 6 commits into from
Closed

Regen bindings #14354

wants to merge 6 commits into from

Conversation

@Manishearth
Copy link
Member

Manishearth commented Nov 24, 2016 •
edited by larsbergstrom

(based on #14330)

This change is Reviewable
upsuper and others added 6 commits Nov 22, 2016
@upsuper
Add stylo FFI for CSSRuleList
9d4ab0d
@upsuper
Add stylo FFI for CSSStyleRule
a9296bc
@upsuper
Add stylo FFI for cssText getters of CSSStyleRule
66669e4
@upsuper
Add stylo FFI for CSSStyleRule.style
9ee2ec5
@upsuper
Add FFI for debug info of CSSStyleRule
Loading status checks…
3c5871f
@Manishearth
Regen bindings
Loading status checks…
5636a29
@highfive
Copy link

highfive commented Nov 24, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/binding_tools/regen.py, components/style/gecko_bindings/structs_release.rs, components/style/stylesheets.rs, components/style/gecko/conversions.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, ports/geckolib/glue.rs, components/style/binding_tools/regen.py, components/style/gecko_bindings/structs_release.rs, components/style/stylesheets.rs, components/style/gecko/conversions.rs
@highfive
Copy link

highfive commented Nov 24, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
emilio approved these changes Nov 24, 2016
View changes
Copy link
Member

emilio left a comment

r=me if needed, though check w/ @bholley, since this is going to bitrot #14300
components/style/binding_tools/regen.py
@@ -328,9 +328,15 @@
"nsStyleVisibility",
"nsStyleXUL",
],
"array_types": {
"uintptr_t": "usize",

This comment has been minimized.

Sign in to view
@emilio

emilio Nov 24, 2016

Member

Such an abuse... :(

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Nov 24, 2016

Author Member

I didnt make it :)
@jdm jdm assigned emilio and unassigned jdm Nov 25, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2016

☔ The latest upstream changes (presumably #14457) made this pull request unmergeable. Please resolve the merge conflicts.
@emilio
Copy link
Member

emilio commented Dec 5, 2016

This is now stale as of #14457, so I'm closing this. Let me know if something here needs landing though.
@emilio emilio closed this Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
S-awaiting-review S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Manishearth @highfive @bors-servo @emilio @jdm @upsuper
You can’t perform that action at this time.